Code Monkey home page Code Monkey logo

Comments (6)

elyase avatar elyase commented on April 27, 2024

Thanks for noticing that, I was getting crazy thinking I made something wrong. These are the results for 0.70:

>>> toks = nlp("They ate the pizza with anchovies.")
>>> printDeps(toks)
They SUB PRON [] []
ate ROOT VERB ['They'] ['.', 'with', 'pizza']
the NMOD DET [] []
pizza OBJ NOUN ['the'] []
with VMOD ADP [] ['anchovies']
anchovies PMOD NOUN [] []
. P PUNCT [] []

>>> toks = nlp("i don't have other assistance")
>>> printDeps(toks)
i SUB PRON [] []
do ROOT VERB ['i'] ['have', "n't"]
n't VMOD ADV [] []
have VC VERB [] ['assistance']
other NMOD ADJ [] []
assistance OBJ NOUN ['other'] []

>>> toks = nlp("I have no other financial assistance available and he certainly won't provide support.")
>>> printDeps(toks)
I SUB PRON [] []
have VMOD VERB ['I'] ['assistance']
no NMOD DET [] []
other NMOD ADJ [] []
financial NMOD ADJ [] []
assistance OBJ NOUN ['no', 'other', 'financial'] ['available']
available NMOD ADJ [] []
and VMOD CONJ [] []
he SUB PRON [] []
certainly VMOD ADV [] []
wo ROOT VERB ['have', 'and', 'he', 'certainly'] ['.', 'provide', "n't"]
n't VMOD ADV [] []
provide VC VERB [] ['support']
support OBJ NOUN [] []
. P PUNCT [] []

# with a comma

>>> toks = nlp("I have no other financial assistance available, and he certainly won't provide support.")
>>>  printDeps(toks)

I SUB PRON [] []
have VMOD VERB ['I'] ['assistance']
no NMOD DET [] []
other NMOD ADJ [] []
financial NMOD ADJ [] []
assistance OBJ NOUN ['no', 'other', 'financial'] ['available']
available NMOD ADJ [] []
, P PUNCT [] []
and VMOD CONJ [] []
he SUB PRON [] []
certainly VMOD ADV [] []
wo ROOT VERB ['have', ',', 'and', 'he', 'certainly'] ['.', 'provide', "n't"]
n't VMOD ADV [] []
provide VC VERB [] ['support']
support OBJ NOUN [] []
. P PUNCT [] []

from spacy.

elyase avatar elyase commented on April 27, 2024

Comparing with version 0.70 it looks like when dependencies are missing in 0.83, they are ROOT in 0.70.

from spacy.

honnibal avatar honnibal commented on April 27, 2024

Okay, I've got the root label bug sorted out.

I've also investigated a potential loss of parse quality. I've fixed some bugs that were long present, and parse quality is actually up slightly over previous metrics. However, the specific eat/pizza/anchovies case is a difficult PP attachment example, and the model may get any individual case such as this incorrect.

Do you have evidence of aggregate performance degradation for your use, outside of the ROOT-label bug?

from spacy.

elyase avatar elyase commented on April 27, 2024

I don't. It seems that most of the problems I was experiencing were related to the ROOT bug.

from spacy.

honnibal avatar honnibal commented on April 27, 2024

Fix for the ROOT bug rolled out in v0.84. Please remember to re-download the data, as bug fixes to the feature calculation mean that the old model will be out-of-sync with the new feature calculation code. Please re-open this issue if the problem does not seem to be resolved.

from spacy.

lock avatar lock commented on April 27, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from spacy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.