Comments (13)
Thanks for the info! This is one of those things where different compilers have different idiosyncracies. We have a namespace anagram
which holds a class anagram
. I think the best way to resolve this is to make them have different names.
from cpp.
Soo can you fix this or what? It would literally take 1 minute.
from cpp.
Hi @lennthevator - for small fixes we always leave the option open to the poster to fix it first, once we've determined that the fix is welcome.
If you don't want to submit a patch, that's totally cool, we can do it. ❤️
from cpp.
I don't know how to submit a patch.
from cpp.
Ok, no problem.
from cpp.
Well I tried to submit a patch, but Travis says that ana
is not a member of anagram
. However, the header file where anagram
is defined is not even in your repository. What gives?
from cpp.
Sample implementations are in example.h
and example.cpp
in the folder for the problem. You will need to change the tests and the implementation. However, ana
is not a good name, IMO. Namespace anagram
and function/class name matcher
reveal more intention than the cryptic ana
, i.e.
BOOST_AUTO_TEST_CASE(no_matches)
{
auto subject = anagram::matcher("diaper");
auto matches = subject.matches({"hello", "world", "zombies", "pants"});
vector<string> expected;
BOOST_REQUIRE_EQUAL_COLLECTIONS(expected.begin(), expected.end(), matches.begin(), matches.end());
}
from cpp.
Alright, so you can change that to matcher
. I'm not going to submit any more pull requests, because you said not to.
from cpp.
I suspect you aren't using gcc 4.8, as the travis build was compiling these just fine with gcc 4.8.
from cpp.
I'm not going to submit any more pull requests, because you said not to.
Please do update pull request #26 which you've already opened, though. Thanks!
from cpp.
So are you saying I should change ana
to matcher
? Should I also update example.h
? I suspect the problem is with my compiler though, as I am using gcc 4.7.3. I will try to update my compiler, and if that works, I'll close the pull request. If not, I'll do what you say to do.
from cpp.
Can someone take a look at my new pull #27 ? I don't know what's happening. I closed #26 by the way.
from cpp.
I figured it out. I wasn't using namspaces at all.
from cpp.
Related Issues (20)
- Missing semi-colon in 'interest-is-interesting' tutorial HOT 4
- Building a training set of tags for cpp HOT 26
- fix: spelling mistake in classes docs
- pop-count: The header file tab is missing. HOT 3
- doctor-data: typo HOT 2
- Doctor Data skeleton contains garbage HOT 2
- ESP-AT: CMake error: Does not match the generator used previously: Ninja HOT 3
- feat: add approaches for leap exercise
- Make double testing more robust for freelancer rates cocnept exercise
- Update test cases HOT 37
- Add #48in24 featured exercises HOT 19
- Tweak troll exercise
- Passthrough mode - I receive ERROR when I send a packet HOT 2
- log-levels concept exercise needs a more fleshed-out stub HOT 3
- parallell-letter-frequency tests are missing some assertions HOT 2
- CI: Only run tests on exercises, when exercise relevant files are changed
- Formatting check in CI is broken HOT 7
- disregard, wrong project :-/ HOT 1
- doctor-data task 4 "get_older_bob" is confusing HOT 1
- robot-name: tests are not sufficient when using mt19937 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cpp.