Anagram Issue with tests about cpp HOT 13 CLOSED

Thanks for the info! This is one of those things where different compilers have different idiosyncracies. We have a namespace anagram which holds a class anagram. I think the best way to resolve this is to make them have different names.

from cpp.

Soo can you fix this or what? It would literally take 1 minute.

from cpp.

Hi @lennthevator - for small fixes we always leave the option open to the poster to fix it first, once we've determined that the fix is welcome.

If you don't want to submit a patch, that's totally cool, we can do it. ❤️

from cpp.

I don't know how to submit a patch.

from cpp.

Ok, no problem.

from cpp.

Well I tried to submit a patch, but Travis says that ana is not a member of anagram. However, the header file where anagram is defined is not even in your repository. What gives?

from cpp.

Sample implementations are in example.h and example.cpp in the folder for the problem. You will need to change the tests and the implementation. However, ana is not a good name, IMO. Namespace anagram and function/class name matcher reveal more intention than the cryptic ana, i.e.

BOOST_AUTO_TEST_CASE(no_matches)
{
    auto subject = anagram::matcher("diaper");
    auto matches = subject.matches({"hello", "world", "zombies", "pants"});
    vector<string> expected;

    BOOST_REQUIRE_EQUAL_COLLECTIONS(expected.begin(), expected.end(), matches.begin(), matches.end());
}

from cpp.

Alright, so you can change that to matcher. I'm not going to submit any more pull requests, because you said not to.

from cpp.

I suspect you aren't using gcc 4.8, as the travis build was compiling these just fine with gcc 4.8.

from cpp.

I'm not going to submit any more pull requests, because you said not to.

Please do update pull request #26 which you've already opened, though. Thanks!

from cpp.

So are you saying I should change ana to matcher? Should I also update example.h? I suspect the problem is with my compiler though, as I am using gcc 4.7.3. I will try to update my compiler, and if that works, I'll close the pull request. If not, I'll do what you say to do.

from cpp.

Can someone take a look at my new pull #27 ? I don't know what's happening. I closed #26 by the way.

from cpp.

I figured it out. I wasn't using namspaces at all.

from cpp.