add requirements to setup.py about jupyter-book HOT 4 CLOSED

for sure, that's a good idea! I think this could be handled by doing something like:

with open('requirements.txt', 'r') as ff:
  lines = ff.readlines()
  install_packages = [ii.strip() for ii in lines]

...

   install_requires = install_packages

PR is welcome :-)

from jupyter-book.

Great! Opening a PR now.

I usually hesitate to read dependencies from the requirements.txt file into the setup.py because of this article.

But, I suppose this distinction is unlikely to matter in jupyter-book, and it would be easier not to maintain two lists that might get out of sync.

from jupyter-book.

yeah, I hear what you mean - gosh python packaging is so confusing to me haha. Let's keep an eye open for whether this ends up messing something up :-)

thanks for the idea and quick turnaround @Zsailer!

from jupyter-book.

gosh python packaging is so confusing to me haha.

You're not alone! 😆

As a side note, Jupyter-book is awesome. It's my python replacement for bookdown. Great work here!

from jupyter-book.