allow changing keepalived_ppa_keyserver variable about ansible-keepalived HOT 5 CLOSED

Hello,

Sorry for the late answer.

It is fairly dangerous to allow this as an override in the role. If it's in vars, it's expected to be non modified. But because you're giving a good reason to override it, I am willing to change our code.

However let's discuss the solutions that don't require code change first:

• You could use another source, like UCA
• You can override the variable with your own value in the cli: -e "keepalived_ppa_keyserver='hkp://keyserver.ubuntu.com:80'" or with -e @<filename>

Yes, I could add a variable file in with first found, but that would require the deployer to set all the variables that are for his distribution, and therefore we'd define "expectations" (deployer would have to follow internal changes in the roles, which sounds problematic).
Alternatively, we could after this "Gather vars for each os" task, have another task to load extra vars if a variable is defined.
But that sounds more a source of problems in the future, compared to the solution above.

from ansible-keepalived.

Hi,

thanks for the explanation. I tried UCA and it worked fine. The idea of using extra params in the shell would it make complicated. Another solution: just store keepalived_ppa_keyserver in default vars and leave the rest where it is.

from ansible-keepalived.

Hey, last question:
Did you use keepalived_ubuntu_src: "uca" for it?

If not needed, I'll not make a change to prevent stability issues.

from ansible-keepalived.

yes I used keepalived_ubuntu_src: "uca"

from ansible-keepalived.

Ok cool, I'll leave this issue closed. If you need anything else, don't hesitate!

from ansible-keepalived.