Mislabeled Behavior? about officeimo HOT 8 CLOSED

Can be PR

from officeimo.

AddParagraphAfterSelf is pretty useful AddParagraphBeforeSelf as well. Basically you can insert new paragraph before the one you're currently operating with. The ones with section isn't really useful i guess. But i could be wrong.

from officeimo.

This is used internally:

and

This could be hidden and made internal/private only. I don't think it doesn't make much sense outside of internal usage.

from officeimo.

Alright thanks, that answered this question.

Would you like me to change the scope of the
method to internal in next pr or leave as is?

from officeimo.

I also should update the signature for AddParagraphBeforeSelf then?

Making the change locally, will open a PR in the future.

from officeimo.

I've made the commit locally, let me know if AddParagraphBeforeSelf shouldn't be made private.

from officeimo.

If it has section then yes. But otherwise no

from officeimo.

BeforeSelf does not have a section argument, but an overload for AfterSelf does. I only need to make the definition with section as an argument private and leave both other method's defined public?

Private: AddParagraphAfterSelf(WordSection section, WordParagraph paragraph = null);
Public: AddParagraphAfterSelf();
public AddParagraphBeforeSelf();

Asking for clarification, right now I moved all three to the private methods file.

from officeimo.