Comments (2)
@mockdeep that's a good idea. At the moment we probably give away TMI:
context "with invalid key" do
...
expect(processor_instance).to receive(:head).with(:forbidden, :text => "Mandrill signature did not match.")
I'm open to suggestions:
- just change this to a generic 404
- or make this a configurable behaviour?
from mandrill-rails.
@tardate, I don't have a strong opinion one way or another. If I were to guess, I would say it's probably safe and simpler to just change it to a 404. It might be a little more confusing for someone debugging their webhook, though, so not sure if you want to maintain both options. I could see something like:
authenticate_with_mandrill_keys! 'YOUR_MANDRILL_WEBHOOK_KEY', fail_with: :not_found
from mandrill-rails.
Related Issues (20)
- Feature Request - Webhook Generator HOT 3
- handle_inbound not working HOT 11
- How to identify mandrill webhook HOT 1
- First draft for engine and activerecord HOT 2
- authenticate_with_webhook_key fails for app enforcing HTTPS through Cloudflare's Flexible SSL HOT 2
- `<module:Mandrill>': uninitialized constant Mandrill::Rails::Application (NameError) HOT 2
- Mandrill::WebHook::EventDecorator class extension not getting loaded HOT 7
- Update CHANGELOG or Releases HOT 1
- undefined ignore_unhandled_events! HOT 3
- Sync events support HOT 1
- Bad email address in bulk emailing HOT 2
- Generator not working HOT 2
- Question about processing the payload HOT 2
- Headers in event_payload object are not hash, but array HOT 8
- Namespace conflict with the official mandrill-api gem HOT 1
- Can't use webhook with content-type application/json HOT 3
- Please release Rails 5 version HOT 7
- how to test handle_ controller events in minitest?
- Deferral (delayed) event type is not supported
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mandrill-rails.