jsonpatch about json-patch HOT 4 CLOSED

Hi. It's been a while since I looked at the repo. But I did take a quick peak at the code, and it seems like when comparing two array values, it goes index by index. So the order would matter.

In your example for the first element in SelectedData, the s1 object where {"ID": 5 ...} would be compared to s2's {"ID"; 1 ...} which obviously wouldn't match up.

So while the unordered contents of SelectedData is the same between s1 and s2, here the order matters.

from json-patch.

Hi again! I noticed that your example JSON is actually malformed.

You have:

"SelectedData":[{"ID": 5, "bla": "hello5"},{"ID": 1, "bla": "hello1"},{"ID": 2, "bla": "hello2"}]

but I would expect it was actually meant to be:

{"SelectedData":[{"ID": 5, "bla": "hello5"},{"ID": 1, "bla": "hello1"},{"ID": 2, "bla": "hello2"}]}

Note the missing braces at the start and end.

In the event that you call jsonpatch.Equal with something that isnt really json, it does a byte comparison. In which case your two strings (not objects) are entirely different.

That said, even if it were fixed, the ordering of objects in an array would still matter, and so s1 and s2 would still be considered unequal.

from json-patch.

Does that help at all?

from json-patch.

@clagraff Thanks for answering the question, yes, it's strict in order.

from json-patch.