Comments (6)
@pacoxu In case it's not clear, I think we agree. Lists should be replaced without editing, i.e. nulls should be preserved. And yes, the spec doesn't have a single example with a null in a list.
from json-patch.
I'm not a lawyer :-), but here's how I read the spec:
- Section 1, it's arguable whether this means that items in an array should be removed, especially since arrays are supposed to be strictly replaced.
Null values in the merge patch are given special meaning to indicate the removal of existing values in the target.
- Section 2, the example algorithm replaces lists altogether with no changes, as expected:
define MergePatch(Target, Patch): if Patch is an Object: if Target is not an Object: Target = {} # Ignore the contents and set it to an empty Object for each Name/Value pair in Patch: if Value is null: if Name exists in Target: remove the Name/Value pair from Target else: Target[Name] = MergePatch(Target[Name], Value) return Target else: return Patch
from json-patch.
Thanks for your reply @apelisse.
I read the spec, examples from the spec like below.
ORIGINAL | PATCH | RESULT |
---|---|---|
{"a": [ {"b":"c"} ] } | {"a": [1]} | {"a": [1]} |
["a","b"] | ["c","d"] | ["c","d"] |
{"a":"foo"} | null | null |
{"e":null} | {"a":1} | {"e":null, "a":1} |
{} | {"a": {"bb": {"ccc": null}}} | {"a":{"bb": {}}} |
{"a":"b"} | {"a":"c"} | {"a":"c"} |
{"a":"b"} | {"b":"c"} | {"a":"b", "b":"c"} |
{"a":"b"} | {"a":null} | {} |
{"a":"b", "b":"c"} | {"a":null} | {"b":"c"} |
{"a":["b"]} | {"a":"c"} | {"a":"c"} |
{"a":"c"} | {"a":["b"]} | {"a":["b"]} |
{"a":"b"} | ["c"] | ["c"] |
{"a":"foo"} | "bar" | "bar" |
Currently, we want to define examples for arrays with null values:
ORIGINAL | PATCH | Current RESULT | RESULT without pruneNullInArray |
---|---|---|---|
{"a": [ {"b":"c"} ] } | {"a": [1]} | {"a": [1]} | {"a": [1]} |
{"a": [ {"b":"c"} ] } | {"a": [null, 1]} | {"a": [1]} | {"a": [null, 1]} |
["a",null] | [null] | [] | [null] |
["a"] | [null] | [] | [null] |
["a", "b"] | ["a",null] | ["a"] | ["a",null] |
{"a":["b"]} | {"a": ["b", null]} | {"a":["b"]} | {"a":["b", null]} |
{"a":[]} | {"a": ["b", null, null, "a"]} | {"a":["b", "a"]} | {"a":["b", null, null, "a"]} |
Also, it is not possible to
patch part of a target that is not an object, such as to replace just
some of the values in an array.
According to the rfc and the examples, we should not change the array. An array is an object as a whole.
from json-patch.
If this is arguable, an option for this would be necessary.
Let users decide which suits their scenarios.
spec:
properties:
allocations:
items:
nullable: true
type: integer
type: array
For Kubernetes custom resource defined property as type nullable=true
array, nulls should be preserved.
For other cases, nulls may be pruned for purposes.
from json-patch.
I don't think we should ever drop nulls in arrays.
from json-patch.
@evanphx would you release a new version? Thanks.
We probably need to update the version of json-patch used in kubernetes now!
from json-patch.
Related Issues (20)
- Performance Degradation Starting In v5.2.0 HOT 2
- Invalid spec implementation
- RFC Link in README.md returns a 404 error
- nil dereference on empty "replace" on root
- RFC6902 limitations when the document structure is not known in advance HOT 2
- Panic when adding to a non-existing array HOT 1
- jsonpatch.Equal : strange behavior on handling literal unicode string equality HOT 1
- replace operation does not apply: doc is missing path: missing value HOT 2
- github.com/pkg/errors is in maintenance mode HOT 7
- Is this project still maintained:) HOT 1
- Add validation for pre-flight checks HOT 6
- Unable to access invalid index: 1: invalid index referenced HOT 2
- Can not run "add" on root object
- CreateMergePatch: Numbers may get truncated due to always being treated as float64 HOT 3
- move fails with "missing value" if from is "" HOT 4
- `>` character is not decoded properly when applying json patches HOT 3
- Regression in 5.8.0: cannot create `jsonpatch.Operation` object HOT 6
- add on `null` does not work anymore ? HOT 10
- For V4 and V5, the apply results of the values that do not exist in replace are inconsistent. HOT 1
- Dependency github.com/pkg/errors was archived HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from json-patch.