msensor class commands about ev3dev-lang HOT 3 CLOSED

Do you already know which impact this has on the LEGO msensor classes?

Regarding the implementation: I understand that all uppercase commands are consistent with the original sensor modes, but on the other hand DC and servo motors do also have command attributes and there they are all lowercase. IMHO we should unify this.

from ev3dev-lang.

Does the commit message not explain it well enough? Or perhaps I am not understanding what you are asking.

The new attributes are present for all sensors, but in most cases will return an error. There are only 3 or so sensors that actually support commands at the moment.

With regard to mode names, in the case of UART sensors, the name is actually sent from the sensor, so I would like to stick with upper case to be consistent with this. Unfortunately, this is not consistent with most other driver in Linux as they tend to use lower case for everything. I would be OK with changing the commands in the motor classes to upper case though.

from ev3dev-lang.

Actually, after giving it some more though. There are more places where we have modes and commands other that just motor classes (i.e. input and output ports have modes). I'm thinking it would be better to just leave msensor class all uppercase (because of UART sensors) and have everything else lowercase.

from ev3dev-lang.