Impossible to edit mirror when name is subset of other mirror about mirrorbits HOT 9 CLOSED

Edit on the last issue, this seems to be created with a previous version of mirrorbits, there was a MIRROR_z.os6.org key left in the redis database with no other keys / keydata with it. I've manually removed the offending key and was able to reuse the name.

from mirrorbits.

The naming issue also affects removing mirrors:

$ mirrorbits remove test.example.com
secondtest.example.com
test.example.com
$ mirrorbits remove secondtest.example.com
Mirror removed successfully

from mirrorbits.

Nice catch! Thanks a lot :)

from mirrorbits.

just 'lucky' we had two similar names I guess. Thanks for the quick fix 👍

from mirrorbits.

Any chance you could make it possible to change the descriptive name of the mirror ?

from mirrorbits.

Renaming a mirror is quite difficult currently since the mirror identifier is part of thousands of keys in the database. It would require to disable the mirror, replace all matching keys and take it back online. Another option would be to use an intermediate table but that would require a breaking database format change. Your best option here is to remove and add the mirror back but with a different name.

from mirrorbits.

@etix I see, well than we just must be careful not to make mistakes 👍

from mirrorbits.

It's definitely on my TODO-breaking list, I just want to do all breaking changes at the same time, most certainly just before 1.0-stable.

from mirrorbits.

patch for editing names confirmed working, just tested adding a mirror with subsetname, was able to edit and remove it no problem.

from mirrorbits.