wrong error return value about pysmi HOT 10 CLOSED

Thanks for raising this!

So what would be the better behavior?

from pysmi.

I've seen sys.exit(1), that would work fine.

from pysmi.

Do you mean sys.exit(1) here. That totally makes sense to me. Will it fix your issue?

from pysmi.

I don't think so. For example, I'm getting

Created/updated MIBs:
Pre-compiled MIBs borrowed:
Up to date MIBs:
Missing source MIBs: foo-MIB
Ignored MIBs:
Failed MIBs:

after calling mibdump.py --mib-borrower= --destination-directory=. --mib-source=/tmp234234 foo-MIB

.. so I believe the error originates somewhere else or is not caught in this PySmiException. The errors in the else branch with the verbose errors is still executed, according to the stderr output.

from pysmi.

Aha, I see what you mean! Commit 607d6df (master HEAD) should fix that.

from pysmi.

This works nicely, thank you!

Depending on the wanted behaviour one could move the errors output from the verboseFlag part to the lower error checking part. That way, failed and missing mibs will only be logged in error case:

if any(x for x in processed.values() if x == 'missing'):
    exitCode = EX_MIB_MISSING
    sys.stderr.write('Missing source MIBs: %s\r\n' % ', '.join(['%s' % x for x in sorted(processed) if processed[x] == 'missing']))
 
if any(x for x in processed.values() if x == 'failed'):
    exitCode = EX_MIB_FAILED
    sys.stderr.write('Failed MIBs: %s\r\n' % ', '.join(['%s (%s)' % (x, processed[x].error) for x in sorted(processed) if processed[x] == 'failed']))

But that might be personal taste. Your last commit definitely fixes the return code issue 👍

from pysmi.

Btw, any idea when this will show up in pip updates? I'm not familiar with the release/sync procedure.

from pysmi.

I will try to push the next release later today.

from pysmi.

pysmi 0.3.2 has been released

from pysmi.

Thanks again.

from pysmi.