Code Monkey home page Code Monkey logo

Comments (20)

Ninakoru avatar Ninakoru commented on May 26, 2024

Hi, I'll help fixing TQ Vault AE to support the new DLC.

I don't want to waste time redundant work.

Is someone working with the new character save file structure?

from tqvaultae.

HoggeL avatar HoggeL commented on May 26, 2024

Hi, I'll help fixing TQ Vault AE to support the new DLC.

I don't want to waste time redundant work.

Is someone working with the new character save file structure?

Hey Ninakoru, I've done some work so far to support our new save file structure. I'll reference some of our code, then get the fix into TQVaultAE as soon as possible

from tqvaultae.

EtienneLamoureux avatar EtienneLamoureux commented on May 26, 2024

If items have 2 enchantment slots now, we could support it as part of another ticket. It entails menu changes and such.
It would allow us to release something that's not broken quicker. So feel free to consider this when committing a fix.

from tqvaultae.

Ninakoru avatar Ninakoru commented on May 26, 2024

Yeah I'm going directly towards a quick version so people does not lose information moving around items.

So far:

Atlantis DLC Discovery, proper text resources loaded conditionally, proper GUI resources (DONE)

New item property RelicBonus2Id (this one will be long, as there are some item craft/GUI involved)

Until I get something that parses everything fully all info and doesn't lose it...

from tqvaultae.

Ninakoru avatar Ninakoru commented on May 26, 2024

Got it working, tomorrow I will do some extra testing to ensure no data is lost, and I'll make a proper fork -> pull request.

from tqvaultae.

epinter avatar epinter commented on May 26, 2024

Yesterday I've sent a pull request with a initial support for the new save format.
#111

from tqvaultae.

Ninakoru avatar Ninakoru commented on May 26, 2024

I have checked it out, part of the changes are very similar to mine, however I handled the conditional parsing for the new atlantis properties a bit different. Also you missed the new text resources. Anyways your edits should let the Vault work properly at first glance, don't know why they were not checked/approved.

The main difference is that I'm writing with the new format (the three new properties for the second charm/relic) as long as the user has Atlantis DLC, you have to encounter this occurrence first in order to use that new format.

from tqvaultae.

epinter avatar epinter commented on May 26, 2024

The save format changed for everyone, not just for people with DLC. About the resources, I only kept text resources that have items names. I dont have free time to develop beyond the PR I've sent, feel free to use it as a base for your work if you want.

from tqvaultae.

Ninakoru avatar Ninakoru commented on May 26, 2024

Even if all the characters were somewhat migrated/imported and backed up with the new patch, the characters I have that I did not open with the game updated still maintain the old save format.

from tqvaultae.

epinter avatar epinter commented on May 26, 2024

Yes, agree. What I mean it's you don't need to have Atlantis dlc (xpack3 folders) to have a save with new fields (relicName2, etc). A user who dont own the dlc but have game in version 2.1, will have the save in new format.

from tqvaultae.

EtienneLamoureux avatar EtienneLamoureux commented on May 26, 2024

Let's make the decision to only support the fully patched game: let's assume all characters are in the new format

from tqvaultae.

Ninakoru avatar Ninakoru commented on May 26, 2024

Waiting for epinter changes to be reflected on the main version, I have some extra goodies to add on top of his work for a more complete DLC support.

from tqvaultae.

EtienneLamoureux avatar EtienneLamoureux commented on May 26, 2024

I merged just now

from tqvaultae.

Ninakoru avatar Ninakoru commented on May 26, 2024

Great, working on the tooltip for dual relic, the code for the tooltip generation is a bit of a mess... :)

from tqvaultae.

Ninakoru avatar Ninakoru commented on May 26, 2024

I've got ready, before commit, @EtienneLamoureux : Do you want me to upgrade the version on my pull request? I guess 2.7.0 should be fitting.

from tqvaultae.

EtienneLamoureux avatar EtienneLamoureux commented on May 26, 2024

Since this is a breaking change and a big deal, I think I'd want it to go to v3.0.0

from tqvaultae.

Ninakoru avatar Ninakoru commented on May 26, 2024

Oh boy just seen it, just sent the pull request #113 .
Let me know if you want me to edit to and add the V3.0 upgrade, also there's a mess with resources due to how visual studio mess the resource items when you add one entry using their UI.

from tqvaultae.

hguy avatar hguy commented on May 26, 2024

Anyone who can add save files from all versions to the repo for references during dev ?
I only have latest versions.

from tqvaultae.

EtienneLamoureux avatar EtienneLamoureux commented on May 26, 2024

@hguy we'll see what we can do, but support should focus on the latest version only.

from tqvaultae.

EtienneLamoureux avatar EtienneLamoureux commented on May 26, 2024

Thanks everyone, I created a new release with your changes!

from tqvaultae.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.