Does this work with should.js? about bn-chai HOT 7 OPEN

Truffle 5 was released yesterday woop woop https://truffleframework.com/blog/truffle-v5-has-arrived - I am happy to help fix and test this @rzadp - just point me in the right direction as had a look but I am not that familiar with how it all fits together. Let me know if I can help out or if you have any time to look at this.

from bn-chai.

Hello,

I did not hear about should.js before, so bn-chai probably won't work with it.

Is it working for you if you try the expect style?
expect(myValue).to.be.eq.BN(0)

from bn-chai.

Thanks for the quick response @rzadp - I have tried, and I get the following output Invalid Chai property: eq.BN. See docs for proper usage of "eq". when switching to expect(myValue).to.be.eq.BN(0) ?

from bn-chai.

OK, so it looks like should.js is interfering / overwriting Chai properties created by bn-chai.

I guess it's worth trying a different order of initialization, as in:

require('chai')
  .use(require('chai-as-promised'))
  .should();
  .use(bnChai(web3.utils.BN))

If it doesn't help then unfortunately looks like these libs do not work with each other in their current state.

from bn-chai.

Looks like that ordering is possible, I get this require(...).use(...).should(...).use is not a function

from bn-chai.

Attaching a quick debugger it looks to me like all the flag checks return true - not sure if this helps.

from bn-chai.

@jamesmorgan
I looked at this, and I'm not sure where this issue with all flags checked is coming from.

But the way I see it, since you're using should.js, maybe you should be adding eq and other assertions using Assertion.add() from should.js, instead of using this lib which uses chai.Assertion.addProperty?

If this is a blocker then I guess you can just (bn1.eq(bn2)).should.be.true etc, instead of using the lib - after all, the lib doesn't do anything more than wrap this to try and make it a little more expressive like bn1.should.eq.BN(bn2)

At Ethworks we are focusing more on Waffle, which has BN assertions build-in. You can check it out and see if it is of any interest to you.

from bn-chai.