Comments (3)
That's correct, we need this in the front end to convert nodeID into hex before calling the registerDarknode
method of the RenPool
contract. However, It'd also be nice to have this implemented in python since we could use this functionality in the register darknode tests.
@JonathanStefanov do you mind sharing the url that you got when registering the node plus the nodeID (hex) value you have when opening say link?
from renpool.
Yes exactly I had noticed this too, but this conversation should be made in our front end right? When the node operator will set up the pool they will enter the base58 ID in our front end and we will do the conversion there before calling our smart contract with the right address. Correct?
from renpool.
Here's a nice converter in case it helps: https://www.mobilefish.com/services/cryptocurrency/brainwallet.html#converter
from renpool.
Related Issues (20)
- Do we need `.gitattributes` file? HOT 1
- Set up multiple Hardhat networks to test with multiple forking networks HOT 1
- Remove project stale branches HOT 1
- Convert project backlog cards into issues HOT 1
- Update `README` to reflect migration to Hardhat
- Separate `RenPool.test.js` into multiple files HOT 1
- Implement darknode deregistration HOT 1
- Connect RenPool and DarkNode registry contracts HOT 1
- Add Slither to GitHub actions
- Fix reentrancy issue reported by Slither HOT 1
- Add a `receive` or `fallback` function to receive ETH
- Implement `cancelRequestWithdraw` HOT 1
- Setup a darknode on testnet
- Implement a non-reentrancy guard HOT 2
- Clean up Brownie leftovers
- Tidy up `.gitignore` `.env.*` entries HOT 1
- Use `Ownable` from OpenZeppelin HOT 1
- Introduce `RenPoolFactory` contract to keep track of all deployed pools in a central contract HOT 1
- Should we use `SafeMath` from OpenZeppelin? HOT 3
- Consider Lido.finance UX HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from renpool.