Improve known cheat code errors about hevm HOT 2 OPEN

Hi @arcz,

Thanks for this! I have done some work on this, but for the life of me I can't find a way to test it 😆 Please see PR #503

There, the file test/contracts/pass/cheatCodeErrors.sol is what's supposed to trigger the error. However, it seems like the interpreter ignores that there are too few arguments (1 instead of 2). I can't seem to make the interpreter die. If you change the 0x24 to 0x44 there, the hevm.deal works, so indeed it is a correct call.

So I'm stuck at testing my new fix. Do you know how could I write that inline assembly such that the interpreter will die with a BadCheatcode and I could test my error code? On bad selector, it reverts, on incorrect parameters it just runs happily ever after, I'm confused how to actually trigger one of these 😆

Thanks,

Mate

from hevm.

Blocked currently on a good test case and a follow-up review. Perhaps in September when fewer people are on vacation, this will be merged :)

from hevm.