The current approach to making the sha256 functions visible is to patch the header fil

Hmm, the change works fine for the purpose of the <a href="https://github.com/henridf/

Move away from patching sha256.h? about c-kzg-4844 HOT 4 CLOSED

ethereum commented on May 22, 2024

Move away from patching sha256.h?

from c-kzg-4844.

Comments (4)

jtraglia commented on May 22, 2024 1

Alternatively, I've made a PR to expose these functions in blst:

supranational/blst#146

from c-kzg-4844.

xrchz commented on May 22, 2024

Seems like a reasonable idea presuming it works :) - want to make this change as a PR?

from c-kzg-4844.

henridf commented on May 22, 2024

Hmm, the change works fine for the purpose of the nim bindings, but fails CI: https://github.com/henridf/c-kzg-4844/actions/runs/3677224128/jobs/6218899526

from c-kzg-4844.

henridf commented on May 22, 2024

To clarify my above comment - I can build c_kzg_4844.o locally, with warnings but no errors:

$ clang -Wall -I../inc -DFIELD_ELEMENTS_PER_BLOB=4096 -O2 -fPIC -c c_kzg_4844.c
In file included from c_kzg_4844.c:17:
In file included from ./c_kzg_4844.h:30:
In file included from ./../blst/src/sha256.h:9:
./../blst/src/vect.h:179:13: warning: unused function 'exp_mont_384' [-Wunused-function]
static void exp_mont_384(vec384 out, const vec384 inp, const byte *pow,
            ^
./../blst/src/vect.h:181:13: warning: unused function 'exp_mont_384x' [-Wunused-function]
static void exp_mont_384x(vec384x out, const vec384x inp, const byte *pow,
            ^
./../blst/src/vect.h:183:13: warning: unused function 'div_by_zz' [-Wunused-function]
static void div_by_zz(limb_t val[]);
            ^
./../blst/src/vect.h:184:13: warning: unused function 'div_by_z' [-Wunused-function]
static void div_by_z(limb_t val[]);
            ^
4 warnings generated.