Code Monkey home page Code Monkey logo

Comments (5)

lbeder avatar lbeder commented on August 24, 2024

The rationale behind reference UIDs was to allow building a graph of onchain attestations, so indeed, referencing an offchain attestation won't work here. You can consider attesting to an offchain attestation as part of the scheme, or using the timestamping feature.

from eas-contracts.

Chomtana avatar Chomtana commented on August 24, 2024

But the timestamp also doesn't work? Since isAttestationValid is not checking for _timestamps[uid] != 0

from eas-contracts.

lbeder avatar lbeder commented on August 24, 2024

Oh, sorry for not being clear. I've meant that you can reference an offchain attestation by either timestamping it (thus proving in the future that the attestation existed at this time) or by attesting to it via a custom schema. In any case, supporting referencing to offchain attestations explicitly would be definitely something to consider for the next version.

from eas-contracts.

crazyyuan avatar crazyyuan commented on August 24, 2024

Sadly, because of this problem, I spent 2 days checking the contract(a little complicated) implementation problem. After setting the off-chain reference, a custom error will occur in make on-chain attest, but the specific reason will not be prompted, because it is an exception thrown by revert. You'll never know what went wrong, it's a very, very bad design.
The Offchain attestation reference issue should be clearly told to developers in the documentation, otherwise it will be very confusing when the issue occurs.

from eas-contracts.

lbeder avatar lbeder commented on August 24, 2024

I'm sorry that you had a bad experience. We are constantly looking to improve, and I hope that using the latest SDK will help to handle errors more easily.

from eas-contracts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.