Code Monkey home page Code Monkey logo

Comments (5)

ethanresnick avatar ethanresnick commented on June 25, 2024

Good catch!

I've also used this library behind a proxy, and I think I solved this problem by setting express' trust proxy setting to true. IIRC, that then updates req.protocol to uses the value from X-Forwarded-Proto.

Is there some reason not to solve this with trust proxy? (e.g. some security concern I don't know about?) If so, we can talk about other solutions. Otherwise, I'd just use that switch :)

from json-api.

MichaelBoselowitz avatar MichaelBoselowitz commented on June 25, 2024

I didn't know that option existed! This is exactly what I wanted!

That option certainly feels like the proper way to handle this case. I cannot think of any issues with using it (the API is completely isolated behind the proxy). As you may be able to discern, I've never used Node/Express behind a proxy before.

Thanks for the super quick responses to my issues! This is an extremely helpful library, I really appreciate your work. Let me know if I can contribute in any way besides spamming up the issues section. :)

from json-api.

ethanresnick avatar ethanresnick commented on June 25, 2024

I'm glad that worked, and that the library's been useful to yiu! Also, thanks so much for your offer to contribute; your help would certainly be appreciated! Are there any open issues you might want to take a stab at?

from json-api.

MichaelBoselowitz avatar MichaelBoselowitz commented on June 25, 2024

#17 looks like it would be very helpful to me in the near future. When I start the next phase of my project, I'll do some exploring into that issue and see what I can come up with.

from json-api.

ethanresnick avatar ethanresnick commented on June 25, 2024

Awesome! Thanks Michael!

from json-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.