Code Monkey home page Code Monkey logo

Comments (2)

ethanresnick avatar ethanresnick commented on July 23, 2024

The problem with the approach above is that, after the transformation, the new linkage will have to be extracted from the returned resource, and the semantics for that aren't clear. What happens if the transform returns a resource object with no relationship at the path where the linkage was passed in? What happens if it return a resource with multiple relationships? What happens to those extra ones? Etc.

A more unified model would be to have beforeRender/beforeSave receive a resource or a resource identifier object. Then, primary data is represented by: an list of items, a flag for whether the items are full resources or resource identifiers, and a flag for whether the result is semantically singular (in which case the empty list is rendered as null, and the non-empty list is rendered as list[0]). Mapping over that becomes mapping over the internal list and, if it can return a promise for a new result, that logic implements the beforeRender transform.

Let's do the above, but then make whether to transform linkage opt-in through a setting on each type's description. We'll wrap the function we pass to map to do an if instanceof Linkage && registry.tranformLinkage ? userbeforeRender : id.

from json-api.

ethanresnick avatar ethanresnick commented on July 23, 2024

Addressed in c79ec4e

from json-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.