Code Monkey home page Code Monkey logo

Comments (5)

tbaden avatar tbaden commented on August 27, 2024 1

work in progress.
current state:

  • [ADD] Status(is_active) to grid and cron edit
  • [ADD] new actions enable & disable in grid
    todo:
  • write tests
  • handle enabling crons without default frequency

from magento2-cronjobmanager.

peterjaap avatar peterjaap commented on August 27, 2024

@tbaden where can we find this WIP? Since this issue is years old, I'm guessing the code won't be that relevant anymore, but I'd like to work on this to improve it like @schmengler suggested.

We used to use the Kiwicommerce one and that has/had this functionality. It would be fairly easy to port it: https://github.com/kiwicommerce/magento2-cron-scheduler/blob/master/Model/Job.php#L130

from magento2-cronjobmanager.

peterjaap avatar peterjaap commented on August 27, 2024

Ok this was actually a lot easier than thought, I could re-use a bunch of code.

Disabling was just setting the cron expression to empty, and re-enabling it is basically thesame as restoring to system defaults.

See #202

from magento2-cronjobmanager.

peterjaap avatar peterjaap commented on August 27, 2024

One thing I found is that because of the custom renderer I added to show disabled jobs, it now shows certain jobs as disabled but they aren't. That is because of #201. So we should actually fix and merge that one before merging this.

Edit; also fixed in #203

from magento2-cronjobmanager.

fredden avatar fredden commented on August 27, 2024

This has been implemented in #202 which landed in v2.2.0

from magento2-cronjobmanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.