plugin could/should set min/maxZoom defined in service metadata automatically about esri-leaflet-renderers HOT 7 CLOSED

The advantage of putting it in a separate plugin is that it can be built and maintained separate from either esri-leaflet or this plugin. Then when we decide which one it belongs in we just include it in the build process so that the user only needs to worry about one plugin. I like the idea of 'micro' plugins as it keeps the core functionality of the original plugin cleaner.

from esri-leaflet-renderers.

That seems reasonable, I had intended to keep this plugin confined to the Drawing Info in the metadata but it does feel like a 'renderer' type of thing. I think it should be similar to the styles where it would only be applied if the user did not define a min/maxZoom.

from esri-leaflet-renderers.

i like the sound of that. but on the other hand, i could also just write a demo app in esri-leaflet that shows how to interrogate your own layer and set the properties dynamically.

any thoughts @patrickarlt?

from esri-leaflet-renderers.

The code is so minimal I'm in favor of leaving min/max scale in this plugin (allowing you to override on the layer options) and just having @jgravois do an example.

from esri-leaflet-renderers.

I'm closing this in favor of Esri/esri-leaflet#426 as the code is not as minimal as initially expected.

from esri-leaflet-renderers.

Hey guys, sorry for chiming in late here, but here's a few additional thoughts. If a user takes the time to set the renderer symbology for a FeatureLayer (most likely by using the Map Viewer) then they mostly likely took time to set the zoom levels too. There's definitely a solid usability relationship between the two and it's definitely frustrating when client apis don't respect those meta settings. I just went through this whole exercise on a recent project and ran into the zoom level limitation with esri-leaflet. Therefore, it definitely feels a little strange that this functionality 1) wouldn't be built into core as an optional setting (true by default), or 2) it wouldn't be built into this repo since symbols and zoom levels are so closely related. A whole plugin just to toggle layers on and off?

from esri-leaflet-renderers.

I think we are all talking around 2 different problems here.

1. Automatically using min/max zoom from the service metadata for FeatureLayers this is what @kneemer and @jgravois have been discussing
2. Automatically using min/max zoom from the service metadata for TileLayers this is the problem that @alaframboise had (since Esri Leaflet only updated the dark gray basemap yesterday)

Building this into the base of the library seems problematic because it adds a lot of complexity, mostly because layer drawing is controlled based on min/max zoom and we have to check if its with range before drawing. Its another request and adds a decent amount of complexity and it means we have to delay drawing for another round trip.

Leaflet also doesn't support dynamically setting the min/max zoom after the fact. It only checks it at the time you add the layer to the map. So in addition to having to alter the drawing code we also have to use some of the internal methods to update the zoom range which seems a bit messy.

Maybe a better way around this is to wrap creating the proper options object from the metadata as a helper method for users.

// the getOptions comes from a plugin
L.esri.FeatureLayer.getOptions(url, function(error, options){
  L.esri.featureLayer(url, options).addTo(map);
});

from esri-leaflet-renderers.