Component: Dropdown about calcite-design-system HOT 6 CLOSED

Proposed component structure, looking for feedback, some q's.

<calcite-dropdown>
  <calcite-dropdown-group>
    <span slot="dropdown-header">Group 1</span>
    <calcite-dropdown-item>Foo</calcite-dropdown-item>
    <calcite-dropdown-item active>Baz</calcite-dropdown-item>
    <calcite-dropdown-item>Bar</calcite-dropdown-item>
  </calcite-dropdown-group>
  <calcite-dropdown-group>
    <span slot="dropdown-header">Group 2</span>
    <calcite-dropdown-item>Zip</calcite-dropdown-item>
    <calcite-dropdown-item active>Zap</calcite-dropdown-item>
  </calcite-dropdown-group>
</calcite-dropdown>

<calcite-dropdown>

• Assign a GUID
• props: theme=(dark/light)
• methods: openCalciteDropdown, closeCalciteDropdown
• events: calciteDropdownOpen, calciteDropdownClose (emit dropdown ID)

<calcite-dropdown-group>

• Assign a GUID

<calcite-dropdown-item>

• Assign a GUID
• attributes: active (should we support multiple active within a single group? Is there a use case for that?)
• events: calciteDropdownItemSelected / deselected (emit dropdown ID, group ID, item ID (or value??))

from calcite-design-system.

@macandcheese this looks good to me. I'm assuming this would follow these designs:

I do have 2 questions:

1. Should this support things not in a group? for example:

   <calcite-dropdown>
       <calcite-dropdown-item>Foo</calcite-dropdown-item>
       <calcite-dropdown-item active>Baz</calcite-dropdown-item>
       <calcite-dropdown-item>Bar</calcite-dropdown-item>
   </calcite-dropdown>

   Here is how we would use this in VTSE:

   

2. Maybe <calcite-dropdown-group> could just have a label property rather then a slot? Since we probably just want to allow text there rather then tab headers which could be icon + text.

   <calcite-dropdown>
     <calcite-dropdown-group label="Group 1">
       <calcite-dropdown-item>Foo</calcite-dropdown-item>
       <calcite-dropdown-item active>Baz</calcite-dropdown-item>
       <calcite-dropdown-item>Bar</calcite-dropdown-item>
     </calcite-dropdown-group>
     <calcite-dropdown-group label="Group 1">
   
       <calcite-dropdown-item>Zip</calcite-dropdown-item>
       <calcite-dropdown-item active>Zap</calcite-dropdown-item>
     </calcite-dropdown-group>
   </calcite-dropdown>

3. Maybe a size prop with a possible `compact value?

I can't really see anyone needing multiple active items in a single group but if there is a valid use case I don't see why not.

One last thing (I keep thinking of stuff) it would be useful to customize the appearance of the button via a <slot>:

<calcite-dropdown>
  <button slot="button" class="btn btn-small btn-white">Dropdown Menu</button>
  <calcite-dropdown-group label="Group 1">
    <calcite-dropdown-item>Foo</calcite-dropdown-item>
    <calcite-dropdown-item active>Baz</calcite-dropdown-item>
    <calcite-dropdown-item>Bar</calcite-dropdown-item>
  </calcite-dropdown-group>
  <calcite-dropdown-group label="Group 1">

    <calcite-dropdown-item>Zip</calcite-dropdown-item>
    <calcite-dropdown-item active>Zap</calcite-dropdown-item>
  </calcite-dropdown-group>
</calcite-dropdown>

from calcite-design-system.

I'm assuming this would follow these designs:

Yep! It was actually already added in CW2.0 branch, https://github.com/Esri/calcite-web/blob/2.0/lib/sass/calcite-web/components/_dropdown.scss, just going to port over and add the dark theme variant.

1. Should this support things not in a group? for example:

Yeah, totally. I had just imagined that being a wrapper in the case where there ARE more than one group - mostly for emitting a containing group ID. I'll make it work without as well.

2. Maybe <calcite-dropdown-group> could just have a label property rather then a slot? Since we probably just want to allow text there rather then tab headers which could be icon + text.

Makes sense, I'm always in favor of "locking down" as much as possible to prevent folks from putting not... good looking stuff in, ha.

3. Maybe a size prop with a possible `compact value?

Yeah I think thats useful here, as well in other components potentially. Could be something set globally (and still explicitly override-able) alongside theme - for VTSE or other 'dense' apps. Maybe some adjustments to font-size and the $baseline padding variable could work.

I can't really see anyone needing multiple active items in a single group but if there is a valid use case I don't see why not.

Hm, that would make a better case for using "super multi select" vs. here, where a click would "deselect" all other items in the group. Open to discussion on that.

One last thing (I keep thinking of stuff) it would be useful to customize the appearance of the button via a <slot>:

I think the invoking element is actually outside the scope of dropdown component itself? ie...

<button class="btn" onclick="document.querySelector('#dropdown-one').toggleCalciteDropdown()">
Dropdown Menu
</button>

<calcite-dropdown id='#dropdown-one'>
...
</calcite-dropdown>

from calcite-design-system.

<button class="btn" onclick="document.querySelector('#dropdown-one').toggleCalciteDropdown()">
Dropdown Menu
</button>

<calcite-dropdown id='#dropdown-one'>
...
</calcite-dropdown>

I have 2 problems with this code snippet:

1. To which element do we "attach" the dropdown? It isn't 100% clear that we want to attach our dropdown to the <button> element.
2. This would require an imperative API which I would really like to avoid for components. Creating an imperative API makes integration harder since users have to get a ref to the component and call a method on it. Definitely possible and in most cases easy but it leave more room for error.

from calcite-design-system.

That's fair - I'll update to use a slot for the invoking element.

from calcite-design-system.

PR in - #96

from calcite-design-system.