Comments (4)
@macandcheese since dir
and lang
are actual HTML attributes should we just look them up from the DOM as I'm doing now?
from calcite-design-system.
Currently have this working for "theme" via a wrapping component and state tunnel. The global config props are all passed to and validated in the "calcite-config" component and tunneled through a ConfigInterface to a child component.
In the child component we just check if a "theme" prop is requested in DOM, and if not, fall back to the globally configured one. Works well for "theme" on alert and tabs, going to try and hook it up for "dir" and "lang" and can do a PR for feedback.
from calcite-design-system.
Yeah that's the plan, just look it up in the Config vs. in each component that needs access to it. I realize I made it sound like folks would need to specify on the Config as a prop, not the case.
from calcite-design-system.
I think this has been tabled for now, closing, can reference prior PR for ideas if we tackle this down the road.
from calcite-design-system.
Related Issues (20)
- Ensure toAriaBoolean is used in rendering HOT 2
- calcite-alert: Long continuous text message is cutoff in the calcite-alert component HOT 1
- [Panel] Add `"content-bottom"` slot
- [Panel] Add `"content-top"` slot, deprecate `"action-bar"` slot
- [Panel & Flow Item]: Refactor `"footer"` slot to account for `modal` HOT 6
- bug(modal, sheet): deprecate `focusTrapDisabled` property HOT 2
- [Input] Remove `type="textarea"`
- CalciteCombobox close button behavior HOT 2
- [Input Time Picker & Input Date Picker] consistent floating picker treatment
- Unskip `calcite-action-menu › Keyboard navigation` tests
- [List] Dismissed `closable` List Items leave behind extra space HOT 2
- Calcite tabs broken with React + Vite HOT 2
- UI that cancels `click` events prevents popovers from auto-closing HOT 9
- Remove component usage examples from repo
- [modal / date-picker] Calendar can be hidden by modal HOT 2
- [input time picker] Update the open picker to make the ability to search more obvious HOT 2
- [input time zone] Update and re-organize timezone dropdown options for improved usability HOT 1
- [input time zone] add a time zone picker null state HOT 7
- Calcite Buttons do not behave consistently with HTML Buttons within a CSS Flex container HOT 2
- [combobox] highlight matching search terms HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from calcite-design-system.