Cannot infer type of optional SPI pins about esp-hal HOT 6 CLOSED

I think that's probably the least painful path forward for now. We can always change it later if need be, not the end of the world.

from esp-hal.

As a note it is possible to construct the spi block as is. A valid gpio type needs to be given. E.g.

    let spi = hal::spi::Spi::new::<
        _,
        _,
        hal::gpio::Gpio0<Input<PullDown>>,
        hal::gpio::Gpio0<Input<PullDown>>,
    >(
        peripherals.SPI2,
        sclk,
        mosi,
        None,
        None,
        2u32.MHz(),
        hal::spi::SpiMode::Mode1,
        &mut pcc,
        &clocks,
    );

Maybe providing a valid No Pin type would be an easier fix. But then the user would have to provide that No Pin type in the generics

from esp-hal.

That is what I originally introduced the no-pin type for .

We need a similar solution here

from esp-hal.

Something like we have for serial:

from esp-hal.

@jessebraham to solve this like we did for UART we need a bunch of constructors which take combinations of the optional pins

while I guess for UART it was sane to have one with all four pins and one with only TX and RX I don't know how to handle this here

IMHO all 4 pins should be optional which gives 16 combinations (well 15 since "no pin at all" doesn't make sense)

maybe not all combinations are really useful but still - should I just make a suggestion of constructors and if we find something is missing, we just add it as a non-breaking change?

from esp-hal.

Closed by #122

from esp-hal.