Support for powershell core about logging HOT 7 CLOSED

Disregard my previous comment, cannot reproduce.

I removed the random start-sleep and saw the errors displayed...

[2019-05-22 13:19:35-04] [ERROR  ] Message n. 97
Out-File : Cannot find drive. A drive with the name 'C' does not exist.
At /Users/jason.chester/.local/share/powershell/Modules/Logging/4.1.1/targets/File.ps1:32 char:17
+         $Text | Out-File @Params
+                 ~~~~~~~~~~~~~~~~
+ CategoryInfo          : ObjectNotFound: (C:String) [Out-File], DriveNotFoundException
+ FullyQualifiedErrorId : DriveNotFound,Microsoft.PowerShell.Commands.OutFileCommand

from logging.

since $PSEdition isn't available before PS 5.1 a better check might be to test the property itself...

if($initialState.ApartmentState) { $true } 

from logging.

@EsOsO PowerShell/PowerShell#6908. The created InitialSessionState should be MTA by default.

from logging.

Ok, we should drop the ApartmentState assignment ad use deafult

from logging.

Okay, after some testing it seems like this is not true for all PowerShell versions...
I would include the following code snippet.

$initialState = [InitialSessionState]::CreateDefault()
if (Get-Member -InputObject $initialState -Name "ApartmentState" -MemberType Property) {
   $initialState.ApartmentState = [System.Threading.ApartmentState]::MTA
}

from logging.

@jasonchester There is a new version up for download, implementing the wanted check. Could you test the functionality for powershell core with the updated version?

from logging.

@tosoikea this works on powershell core now...

one strange thing I noticed when running the sample code

Set-LoggingDefaultLevel -Level 'WARNING'
Add-LoggingTarget -Name Console
Add-LoggingTarget -Name File -Configuration @{Path = 'C:\Temp\example_%{+%Y%m%d}.log'}

$Level = 'DEBUG', 'INFO', 'WARNING', 'ERROR'
foreach ($i in 1..100) {
    Write-Log -Level ($Level | Get-Random) -Message 'Message n. {0}' -Arguments $i
    Start-Sleep -Milliseconds (Get-Random -Min 100 -Max 1000)
}

Wait-Logging  

is that the system hung... i identified the issue as the path set here:

Add-LoggingTarget -Name File -Configuration @{Path = 'C:\Temp\example_%{+%Y%m%d}.log'}

was not valid on my mac but instead of displaying a meaningful error message, logging appears to hang. One suggestion i would have would be to validate creating a file when adding a target or at least trapping any errors when writing to a target.

Otherwise everything looked great, thanks for the help.

from logging.