Code Monkey home page Code Monkey logo

Comments (5)

tkm-kj avatar tkm-kj commented on September 24, 2024

https://github.com/colorbox/bento/blob/53-freeze-order/app/models/order.rb#L23 のコードも Order 生成するところで休日祝日抜いてるから無くても良さげ。

from bento.

yucao24hours avatar yucao24hours commented on September 24, 2024

#32 (comment)

仮でいれてました。Order レコードつくるところでそこは取りますね。

from bento.

yucao24hours avatar yucao24hours commented on September 24, 2024

これ、 #42 で Order の存在する前提条件が変わる(土日祝日がなくなる)ので、on_weekday というインスタンスメソッドをなくして、コントローラ order#index

def index
  @orders = Order.where('date > ?', Time.current.to_date).limit(14).order(date: :asc)
end

って書くだけにできちゃうんじゃないかなーと思っております 💭 ( where 以降が長くてちょっとな〜ってことならもちろん scope とかを定義してもいいとおもいます)

from bento.

tkm-kj avatar tkm-kj commented on September 24, 2024

確かにModelに寄せなくても良さそうですね!
2週間出すなら10営業日なので limit(10) の方がより厳密かなと(とはいえ、そこまで厳密にする必要もないのでおまかせですけど)

from bento.

colorbox avatar colorbox commented on September 24, 2024

🔚 to close

from bento.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.