Bot sometimes adds `triage` label to its own issues about eslint-github-bot HOT 5 CLOSED

@bkeepers and @hiimbex would really appreciate your insight into this. Thanks a lot.

from eslint-github-bot.

(Note: This issue wasn't originally intended to be a bug report to GitHub, but I'll add some more info since a few people have been pinged already. Let me know if I should report this somewhere else.)

Here's some more information about the particular events:

• X-GitHub-Delivery: fafe2c30-bdf8-11e7-922b-a3c8d44a5819 is an example of a case where an issue-opened payload already contained the initial label on the issue. (This was followed by the fb061b70-bdf8-11e7-9188-71dde51a7192 delivery for adding the label.)
• X-GitHub-Delivery: 041a7a80-bdf9-11e7-8c3c-936b8cd0b1a1 is an example of a case where an issue-opened payload did not contain the initial label on the issue. (This was followed by the 0422def0-bdf9-11e7-91ff-209baad94d9a delivery for adding the label.)

In both cases, the issue was created with labels using the labels option on node-github, which I think maps directly to the labels GitHub API option when creating the issue. Since the label is added at the same time as the issue is created, I would expect the initial issue-opened payload to always contain the label (or, at least, I would expect the behavior to be consistent).

from eslint-github-bot.

I have not had a chance to look into this issue in depth (I will try shortly); however, I am aware of several similar race conditions that occur within the GitHub API. So the solution may be just waiting until after the payload had been received and making a follow up API call to get the correct label data.

from eslint-github-bot.

Thanks for the response, that seems reasonable to me. Do you think making a separate API request would always avoid the issue? (My thinking is that if the issue is in an intermediate state without labels at the time that the webhook gets sent, it seems plausible that it would still be in the intermediate state when the next API call arrives. But I'm not sure whether that is actually a possibility.)

from eslint-github-bot.

I would imagine the additional API call would solve the problem, but not sure. Also the context.isBot method might also be useful to ignore issues created by the bot itself.

from eslint-github-bot.