Code Monkey home page Code Monkey logo

Comments (12)

fisker avatar fisker commented on June 27, 2024 1

I see, but we can still use script to generate them, and modify if nessary.

from eslint-define-config.

fisker avatar fisker commented on June 27, 2024 1

Okay, I'll try, going to sleep now.

from eslint-define-config.

Shinigami92 avatar Shinigami92 commented on June 27, 2024

can we add support for eslint-plugin-unicorn

Sure! It is highly extendable 🙂

There is already support for e.g. jsdoc and other stuff.

Do you want to try it and open a PR?

Will grant you write access so you don't need to fork

There is also a script to generate a rule

https://github.com/Shinigami92/eslint-define-config/blob/435ca836125e7228ad8afce9ee3909207c309eb1/package.json#L13

from eslint-define-config.

fisker avatar fisker commented on June 27, 2024

Do you want to try it and open a PR?

Sorry, but I don't use ts at all.

from eslint-define-config.

Shinigami92 avatar Shinigami92 commented on June 27, 2024

Sorry, but I don't use ts at all.

I will not hurt you 😏
Or will it? 👀


Could you write your top 10 most used rules of eslint-plugin-unicorn?
Then I could add these.
The generation is not that automated 🙁 So I need to hand-write every rule on its own...
That's why I mostly support first the rules that are common used.

from eslint-define-config.

fisker avatar fisker commented on June 27, 2024

I had a quick look on the script, you're hard coding the docs links, why not load the rule, links exists in their meta.

Can these options generated from the schema?(Just an idea.)

from eslint-define-config.

Shinigami92 avatar Shinigami92 commented on June 27, 2024

I had a quick look on the script, you're hard coding the docs links, why not load the rule, links exists in their meta.

Can these options generated from the schema?(Just an idea.)

Every plugin has a different kind of structure and generating them automatically would not result in such good types than with handcrafted types and JSDoc.

from eslint-define-config.

fisker avatar fisker commented on June 27, 2024

Every plugin has a different kind of structure

Can you explain?

from eslint-define-config.

Shinigami92 avatar Shinigami92 commented on June 27, 2024

In example https://github.com/aotaduy/eslint-plugin-spellcheck/blob/master/rules/spell-checker.js doesn't have a link to the docs I manually added

https://github.com/Shinigami92/eslint-define-config/blob/435ca836125e7228ad8afce9ee3909207c309eb1/src/rules/spellcheck/spell-checker.d.ts#L68

And e.g. https://github.com/Shinigami92/eslint-define-config/blob/435ca836125e7228ad8afce9ee3909207c309eb1/src/rules/spellcheck/spell-checker.d.ts#L22-L26

this was copied from the docs

https://github.com/aotaduy/eslint-plugin-spellcheck#configuration-options

from eslint-define-config.

Shinigami92 avatar Shinigami92 commented on June 27, 2024

Please feel free to create a draft. And feel free to do that in plain js for now.
If it works I can convert it to ts later on.

Just create a branch/PR and feel free to escalate 😄

from eslint-define-config.

Shinigami92 avatar Shinigami92 commented on June 27, 2024

Okay, I'll try, going to sleep now.

Added you on Discord 👀

from eslint-define-config.

Shinigami92 avatar Shinigami92 commented on June 27, 2024

Finally I found some free time to work on an automation to generate the rules

I added support for your requested plugin 🎉

cabba8d

Will be released in 1.1.0

from eslint-define-config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.