Code Monkey home page Code Monkey logo

Comments (6)

xjamundx avatar xjamundx commented on May 19, 2024 2

I don't think I agree with this, because then the rule becomes less helpful to many people. Is there a specific case where it's handling bluebird (or other style) promises incorrectly?

from eslint-plugin-promise.

tamirmen avatar tamirmen commented on May 19, 2024 2

The problem is not incorrect handling but rather more than the standard.
There is a big benefit (advantage) to stick to the standard in order to avoid "locking" to a specific library. Otherwise, when you want to switch to different promises library (common situation) it becomes very problematic.
I understand the argument that the rule becomes less helpful to many people; for sure if you are not considering long-term development. So, the rule can be provided as default with "off" or "warn".

from eslint-plugin-promise.

xjamundx avatar xjamundx commented on May 19, 2024 1

@tamirmen, @lidortal I think I misunderstood the proposal. Your suggestion here is a rule that might look like this:

"promise/spec-only": "error"

Which would effectively ban you from doing any of the non-spec stuff like p.done() or Promise.try?

I think I'm okay with this idea, could you put together a proposal of what exactly should result in an error?

from eslint-plugin-promise.

lidortal avatar lidortal commented on May 19, 2024 1

Yes, this is the idea.

IMO when someone uses non-spec stuff, an error should be returned with the message - follow the standard.
For example:
prom.then() - wouldn't return an error.
prom.spread() - would return an error.

from eslint-plugin-promise.

ShimiT avatar ShimiT commented on May 19, 2024

@xjamundx - is there any progress on this topic?

from eslint-plugin-promise.

macklinu avatar macklinu commented on May 19, 2024

#72 is related to this issue and has some useful test cases and implementation suggestions that would help in resolving this feature request.

Help is wanted with a PR, but I will try to open a PR in the next week or so. Please communicate if you would like to contribute this feature!

from eslint-plugin-promise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.