`mod_blocking` doesn't stop messages from being processed by `modules.mod_mam.pm` or `mod_inbox` about mongooseim HOT 2 CLOSED

Not a bug, just a pretty inconsistent XMPP behaviour.
mod_blocking is based on mod_privacy, and mod_privacy needs some list to be activated on connect (but I think there is a default list too).

mod_mam has its own "privacy" settings. i.e. before they were in XEP-0313, now they got a separate XEP:
Oh, there is literally this XEP too https://xmpp.org/extensions/attic/xep-0441-0.2.0.html

Preferences ARE supported, you can do it.

<iq type='set' id='juliet3'>
  <prefs xmlns='urn:xmpp:mam:2' default='roster'>
    <always>
      <jid>[email protected]</jid>
    </always>
    <never>
      <jid>[email protected]</jid>
    </never>
  </prefs>
</iq>

I.e. you need to set list of jids to block once for mod_blocking and once for MAM preferences.

Theoretically we could just copy mod_mam_rdbms_prefs module to create mod_mam_blocking_prefs and hook it to use the list from mod_blocking. Except, it makes prefs read only (i.e. only updatable though mod_blocking API).

Except, it would not fully fix mod_inbox blocking.
Except, the behaviour for multichat rooms is undefined (i.e. you probably wanna put a spoiler on the client for that and adjust the push settings, but it would require work on the client side and someone actually describing what is a preferred behaviour).

Also, maybe we could still want to archive blocked threads (in case we want to unblock the user later), but don't show such threads. But in this case these messages should be filtered out from the list of messages we query when we don't provide with filter (maybe we should have a filter to filter out blocked messages, but good luck to make that efficient on the backend).

At least push service respects mod_blocking (I think).

TLDR: we could integrate MAM with mod_blocking, it would not fix mod_inbox. + the whole behaviour is still not consistent or desired. Once we figure out the consistent behaviour or better XMPP people would make a XEP describing a preferred solution - we could implement it.

from mongooseim.

Thanks for the quick reply! That clarifies things a whole lot. I'll close this issue for now.

from mongooseim.