Comments (4)
I think the problem is that we're using on
/off
methods for event binding instead of listenTo
, stopListening
.
MarkerView#close
calls model.off()
on it's Location
model. This unbinds all events from the model, not just the events which were relevant to the MarkerView
Would you be up for putting together a pull request that fixes this?
from backbone.googlemaps.
@eschwartz yes, sure, that's something I actually began doing already. Question, maybe you know the answer, if not it will become clear when I fully implement. When using stopListening, it will unbind all events, but the behavior of listenTo should unbind without needing to call stopListening on destruction of the view. Is stopListening necessary in this case?
from backbone.googlemaps.
but the behavior of listenTo should unbind without needing to call stopListening on destruction of the view
Events bound with listenTo
will only be unbound when you call stopListening
-- I guess I'm not sure exactly what you mean.
from backbone.googlemaps.
I'm going to close this for inactivity. Let me know if you're still having problems.
from backbone.googlemaps.
Related Issues (19)
- Custom icons HOT 9
- Uncaught Error: bindAll must be passed function names HOT 3
- Selecting a LocationModel in a LocationCollection Deselects All Other LocationModels in All Other Location Collections HOT 1
- `this.options` undefined in constructor HOT 1
- mapEvents handlers should be bound to the object, not the map marker HOT 3
- Unable to get this to work in backbone marionette. HOT 3
- latlng changed before gOverlay not completely created HOT 2
- overlayOptions not copied to MapView.overlayOptions HOT 5
- Error initializing MarkerCollectionView HOT 3
- Richmarker Support HOT 3
- Event for when the pins have been added to the dom HOT 2
- Enforce closing infoWindow when another is open HOT 4
- MarkerClustererPlus support HOT 4
- OverLappingMarkerSpiderfier intergration HOT 1
- Unbind / Remove Listeners HOT 3
- Rails Assets compatibility HOT 3
- Pulling location data via external JSON URL? HOT 2
- Ability to update markerview's position on map HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backbone.googlemaps.