Code Monkey home page Code Monkey logo

Comments (4)

eschwartz avatar eschwartz commented on July 19, 2024

I think the problem is that we're using on/off methods for event binding instead of listenTo, stopListening.

MarkerView#close calls model.off() on it's Location model. This unbinds all events from the model, not just the events which were relevant to the MarkerView

Would you be up for putting together a pull request that fixes this?

from backbone.googlemaps.

halcyonandon avatar halcyonandon commented on July 19, 2024

@eschwartz yes, sure, that's something I actually began doing already. Question, maybe you know the answer, if not it will become clear when I fully implement. When using stopListening, it will unbind all events, but the behavior of listenTo should unbind without needing to call stopListening on destruction of the view. Is stopListening necessary in this case?

from backbone.googlemaps.

eschwartz avatar eschwartz commented on July 19, 2024

but the behavior of listenTo should unbind without needing to call stopListening on destruction of the view

Events bound with listenTo will only be unbound when you call stopListening -- I guess I'm not sure exactly what you mean.

from backbone.googlemaps.

eschwartz avatar eschwartz commented on July 19, 2024

I'm going to close this for inactivity. Let me know if you're still having problems.

from backbone.googlemaps.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.