Code Monkey home page Code Monkey logo

Comments (7)

Yaffle avatar Yaffle commented on May 13, 2024

similar issue with "indexOf"

http://es5.github.com/#x15.4.4.14
step 8b
"if k is less than 0, then let k be 0"

test:

[1].indexOf(3, -1e10);

works very slowly with your implementation

from es5-shim.

michaelficarra avatar michaelficarra commented on May 13, 2024

@Yaffle: fixed by b03315e

from es5-shim.

Yaffle avatar Yaffle commented on May 13, 2024

without additions to test this fixes can be lost onse

from es5-shim.

michaelficarra avatar michaelficarra commented on May 13, 2024

I went to add tests, but then thought... what do I test? It's only really an efficiency thing. I guess we could make array-like-objects with out-of-bounds indices and see if they're found? Can't do the same with real arrays, though, due to the dynamic (read: magic) nature of the length property.

from es5-shim.

Yaffle avatar Yaffle commented on May 13, 2024

what abot calling [].indexOf with array-like object

var x = { length : 1, '-10000' : 'test');
[].indexOf.call(x, 'test', -10001)
?
or something

from es5-shim.

michaelficarra avatar michaelficarra commented on May 13, 2024

Yeah, that's basically what I just suggested. Do you want to submit a patch or should someone else take care of it? I can't do it until at least later tonight.

from es5-shim.

Yaffle avatar Yaffle commented on May 13, 2024

https://gist.github.com/1245607

from es5-shim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.