Comments (6)
Has anyone found a workaround for this that doesn't involve js?
from parsedown-extra.
It looks like this is a bug with parsedown using the string placeholder
as a literal placeholder, and str_replace
-ing that. Would changing placeholder
in the parsedown PHP to something like PD_PLACEHOLDER
fix the issue? (I'd like a sanity-check before making a pull request.)
# because we don't want for markup to get encoded
$DOMDocument->documentElement->nodeValue = 'placeholder';
$markup = $DOMDocument->saveHTML($DOMDocument->documentElement);
$markup = str_replace('placeholder', $elementText, $markup);
from parsedown-extra.
@maxfenton that's correct, it should be resolved now
from parsedown-extra.
@hkdobrev could u have a quick look at the failing build at https://travis-ci.org/erusev/parsedown-extra/jobs/85614579
the failure seems related to late static binding
if the problematic test is too complicated to fix, i'd rather remove it as the instance method, that it tests, is sth that's unlikely to change in future
from parsedown-extra.
@erusev It's failing, because ParsedownExtraTest
extends ParsedownTest
and this way PHPUnit executes both testsuites. I don't think that's needed. However if you really want to keep it this way, we'll need to change the way the TestParsedown.php
file is loaded.
from parsedown-extra.
it extends ParsedownTest
because we want to make sure that "extra" doesn't break the handling the rest of the original syntax
from parsedown-extra.
Related Issues (20)
- Undefined index: text HOT 4
- Paragraphs/HTML blocks may disappear in HTML block with markdown="1" HOT 3
- ParsedownExtra.php and tests classes are declared as psr-0 in composer.json but are not compliant with psr-0 HOT 11
- Bug: Uninitialized string offset: 1
- Footnote HTML is double-escaped when safe mode is on HOT 1
- Can't embed video HOT 1
- The Footnotes stop working
- I'm getting this while composer update/install HOT 2
- Multiline blockquotes not rendering correctly in multiline footnotes
- Multiple blockquotes HOT 1
- Video HTML tag does not work
- Parsing special attributes {lang=fr} are not parsed HOT 1
- List Item is dropping text that follows a custom tag HOT 2
- PHP 8.2: mb_convert_encoding(): Handling HTML entities via mbstring is deprecated HOT 2
- Wrap image inside div - not working
- Demo broken? HOT 5
- Add support for PHP 8.2 HOT 2
- Deprecated: Use of "self" in callables is deprecated HOT 1
- Should we start looking for alternatives? Is this repo alive? HOT 1
- Deprecated: Use of "self" in callables is deprecated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from parsedown-extra.