Code Monkey home page Code Monkey logo

Comments (3)

erikras avatar erikras commented on May 28, 2024

That was the point of this test. Do you still think this is an issue?

from react-callbag-listener.

Andarist avatar Andarist commented on May 28, 2024

This test indeed unsubscribes from a callbag but in a different situation. Imagine other scenario:

const props = this.props.smth % 2 === 0
  ? { first: callbagOne }
  : { second: callbagTwo }
return (
  <ReactCallbagListener {...props}>
    {() => <div />}
</ReactCallbagListener>
)

first won't get unsubscribed when it stops being used, as its under non-existing key in this.props after a re-render.

from react-callbag-listener.

erikras avatar erikras commented on May 28, 2024

Duh. I was going to do this, but then I forgot. Good eye! 👍

from react-callbag-listener.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.