How to calculate "Actual Second/Iteration (Avg)" and explaining a large difference for it given about the same input about sqlquerystress HOT 9 CLOSED

I'm not sure but It looks like GetInfoMessages is firing multiple times for the same connection/query so the elapsed/cpu times are counted more than once (so two messages with 2000 in one and 3000 in the later one = 5000 for that single query). You should be able to replicate by putting a breakpoint on the parsing code and running a test with 1 iteration and 1 thread

Proposed fix:

Track times by connection client ID in a dictionary so the value is only counted once. Then after each query completes allocate that to a global counter.

GetInfoMessages

` //we have times
if (matches.Length > 1)
{
var conn = (SqlConnection)sender;
var id = conn.ClientConnectionId;

                    //could probably add this to the connection creation area to tidy it up
                    if (!_outInfo.CpuTimes.TryGetValue(id, out var _))
                    {
                        _outInfo.CpuTimes.Add(conn.ClientConnectionId, 0);
                        _outInfo.ElapsedTimes.Add(conn.ClientConnectionId, 0);
                    }
                    //set the values for this connection to the last known amount
                    _outInfo.CpuTimes[id] = Convert.ToDouble(matches[1], CultureInfo.InvariantCulture);
                    _outInfo.ElapsedTimes[id] = Convert.ToDouble(matches[2], CultureInfo.InvariantCulture);

                    //_outInfo.CpuTime += Convert.ToInt32(matches[1], CultureInfo.InvariantCulture);
                    //_outInfo.ElapsedTime += Convert.ToInt32(matches[2], CultureInfo.InvariantCulture);
                }`

And then QueryOutput updates

` public class QueryOutput
{
public double CpuTime => trackedCpu + CpuTimes.Values.Sum();
public Exception E;
public double ElapsedTime => trackedElapsedTime + ElapsedTimes.Values.Sum();
public bool Finished;
public int LogicalReads;
public TimeSpan Time;

        public ConcurrentDictionary<Guid, double> CpuTimes = new();
        public ConcurrentDictionary<Guid, double> ElapsedTimes = new();

        private double trackedCpu = 0;
        private double trackedElapsedTime = 0;
        private object updateLock = new();


        public void ClearTimes(Guid clientId)
        {
            lock (updateLock)
            {
                if (CpuTimes.TryGetValue(clientId, out double cpu))
                    CpuTimes[clientId] = 0;
                if (ElapsedTimes.TryGetValue(clientId, out double elapsed))
                    ElapsedTimes[clientId] = 0;

                trackedCpu += cpu;
                trackedElapsedTime += elapsed;
            }
        }

...
`

And clear after each query:

//set up the statistics gathering if (_statsComm != null) { _statsComm.ExecuteNonQuery(); Thread.Sleep(0); _outInfo.ClearTimes(conn.ClientConnectionId); }

With these changes my results look more consistent.

I only saw the tool today so I'm not very familiar with it so if that explanation makes sense to you and you can duplicate the multi-message I'm happy to put a PR in with the changes next week when I get some time to tidy it up.

from sqlquerystress.

I also set the setting to true so that all the results are streamed to the client in the 2nd screenshot.
Although I think that isn't relevant give that all the numbers are about the same.

from sqlquerystress.

This is part if the original implementation, and not something I have touched the last 15 years. Maybe there is some info in the wiki?

from sqlquerystress.

Any updates?

from sqlquerystress.

Ideally the metrics displayed are accompanied by an explanation.
I favor a question mark that shows what it conveys when you have over it. This will be some work that I currently don't have the cycles for.
AFAIK there is no documentation that is reachable from the GUI. That would be a place for it as well.

from sqlquerystress.

Does this help? https://github.com/ErikEJ/SqlQueryStress/wiki

from sqlquerystress.

@DannyRichardsonWG Feel free to create a PR!

from sqlquerystress.

@DannyRichardsonWG Any plans to submit a PR?

from sqlquerystress.

@DannyRichardsonWG I am not able to reproduce the duplicate message events

from sqlquerystress.