Code Monkey home page Code Monkey logo

Comments (8)

ericf avatar ericf commented on July 29, 2024

I haven't tried yet. But yeah, I need a new name for this package :)

Too bad the namespace for "express" and "handlebars" is pretty used up :(

from express-handlebars.

jwarykowski avatar jwarykowski commented on July 29, 2024

Hi Eric,

Ha, no worries, I've used it in the latest version of Express and not seeing any major issues from the get go so looks sort of ok. I'll let you know if I run into anything. You can see my kickstarter project here if your interested:

https://github.com/jonathanchrisp/bb-hbs-express-kickstarter

Good luck with the new package name! :)

Cheers,
Jon

from express-handlebars.

cirocosta avatar cirocosta commented on July 29, 2024

Seems like it definetly works well with 4.0 as we can see on expressjs/express#1838 that changes in how the default .render works weren't made:

The view system will remain tied to the app and will not become middleware (too involved). However this does make me a bit sad in that I was hoping to allow subapps/routers to have their own views if they wanted (something currently not supported) but the more I think about it, the more I think this is a hard approach to pull off realistically. The way express is written, an app is meant to be a single instance which contains some settings and sets up a view system. To this end, I think that even allowing for "mounted" apps is now incorrect and will only cause confusion because none of the app settings or even the app view system will work the way someone would expect when they create this subapp and mount it. For route separation, we have a very good Router. I would like to hear form people currently using "subapps" to see if Router would somehow not serve those needs.

from express-handlebars.

bradoyler avatar bradoyler commented on July 29, 2024

Why not change to node-handlebars-templates ?

from express-handlebars.

eberhm avatar eberhm commented on July 29, 2024

+1 on changing name for something less tied up with an express version.
express-handlebars would do the job perfectly

from express-handlebars.

ericf avatar ericf commented on July 29, 2024

@eberhm I agree express-handlebars would be great, but it's already taken :(

from express-handlebars.

ericf avatar ericf commented on July 29, 2024

Closing this since it works with Express 4, name discussion can happen in #65

from express-handlebars.

ericf avatar ericf commented on July 29, 2024

I was able to get express-handlebars, and have now renamed everything.

from express-handlebars.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.