EDIT: this was added but needs more docs and examples. See initial docs here <a href="

I think register isn't going to work. Mostly because things like <code class="notransl

Initial implementation <a href="https://godoc.org/github.com/ericchiang/k8s#Client.Thi

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

docs add here: <a href="https://godoc.org/github.com/ericchiang/k8s#ThirdPartyResource

thirdpartyresource support about k8s HOT 6 CLOSED

ericchiang commented on May 16, 2024

thirdpartyresource support

from k8s.

Comments (6)

barakmich commented on May 16, 2024

That's pretty good. I'd combine those string arguments to a struct, but that's just me:

RegisterThirdPartyResource(ThirdPartyResourceType, interface{})

and

type ThirdPartyResourceType struct {
ApiGroup string
ApiVersion string
Plural string
}

from k8s.

ericchiang commented on May 16, 2024

I think register isn't going to work. Mostly because things like Delete doesn't take a struct argument so there's nothing to reflect and map.

Current working on something like:

func (t *ThirdPartyResources) Create(ctx context.Context, apiGroup, apiVersion, resource string, req, resp interface{}) error {
	url := t.c.urlFor(apiGroup, apiVersion, t.c.namespaceFor(ctx, true), resource, "")
	return t.c.create(ctx, jsonCodec, url, req, resp)
}

func (t *ThirdPartyResources) Get(ctx context.Context, apiGroup, apiVersion, resource, name string, resp interface{}) error {
	url := t.c.urlFor(apiGroup, apiVersion, t.c.namespaceFor(ctx, true), resource, name)
	return t.c.get(ctx, jsonCodec, url, resp)
}

func (t *ThirdPartyResources) Delete(ctx context.Context, apiGroup, apiVersion, resource, name string) error {
	url := t.c.urlFor(apiGroup, apiVersion, t.c.namespaceFor(ctx, true), resource, name)
	return t.c.delete(ctx, jsonCodec, url)
}

func (t *ThirdPartyResources) List(ctx context.Context, apiGroup, apiVersion, resource string, resp interface{}) error {
	url := t.c.urlFor(apiGroup, apiVersion, t.c.namespaceFor(ctx, true), resource, "")
	return t.c.get(ctx, jsonCodec, url, resp)
}