Suggestions/Issues about anitomy HOT 7 CLOSED

577070c...c0687cb resolve these issues.

from anitomy.

Thanks for the suggestions!

"Hi10" and "HEVC2" should be added as keywords.

Just looked them up at Nyaa. Hi10 seems popular enough with multiple fansub groups using it. That said, is HEVC2 really a thing? All releases with this keyword are uploaded by a single person, and searching Google for HEVC2 yields nothing else.

00+00 Multiple episode pattern support. (e.g [HorribleSubs] Momokuri - 09+10 [720p].mkv)

Anitomy actually supports this pattern, but the relevant function doesn't receive it as a single token due to + being a token delimiter. I think I'll need to define a special case for this.

Support for basic roman numerals for volume patterns.

The parser currently relies on the assumption that the following token contains at least one digit, but it should be doable.

Edit: On second though, I don't think we need this. Filenames with this pattern are pretty much nonexistent.

Support for "&" multiple episode patterns

This is similar to the + issue, but more complicated. I'll see what I can do.

[Infantjedi] Norn9 - Norn + Nonetto - 12 results in : "Norn9 - Norn Nonetto"

This may actually be fixed automatically if I can resolve the previous issue.

from anitomy.

Actually, you're right about HEVC2. I made a text dump of all anime filenames of nyaa to test the library and was reviewing each result. I didn't notice the uploader.

Thanks for looking into the other things :)

from anitomy.

As a heads up I ported anitomy to java: https://github.com/Vorror/anitomyJ :D
Quick question about your data.json file. Do you have actually have an automated unit test or do you simply check it visually? I ask because some entries differ than what's actually parsed. Example entries:
[ReDone] Memories Off 3.5 - 04 (DVD 10-bit).mkv (wrong eptitle/number)
Evangelion Shin Gekijouban Q (BDrip 1920x1080 x264 FLACx2 5.1ch)-ank.mkv (ank isn't enclosed therefore ignored)

Do you have some sort of test.cpp that's actually run against the json?

from anitomy.

As another heads up "[TaigaSubs]Toradora!(2008)_-01v2-Tiger_and_Dragon[1280x720_H.264_FLAC][1234ABCD].mkv" which is used in the README doesn't actually find the episode title anymore.

from anitomy.

I ported anitomy to java: https://github.com/Vorror/anitomyJ :D

That looks nice! I should probably add a list of similar projects to the README file some time.

Quick question about your data.json file. Do you have actually have an automated unit test or do you simply check it visually? I ask because some entries differ than what's actually parsed.

I have two of them, actually. The first one is a console application that I use to test the contents of data.json or debug individual filenames. And the other is like this, which helps me get a better look at things and check the performance of the library after every change I make. Both of them are quite messy, which is why I haven't committed them to the public repository.

Indeed, Anitomy returns different results for some entries. Most of them are problematic filenames that should be included in test cases in my opinion, but are ignored due to technical difficulties, etc.

As another heads up "[TaigaSubs]Toradora!(2008)_-01v2-Tiger_and_Dragon[1280x720_H.264_FLAC][1234ABCD].mkv" which is used in the README doesn't actually find the episode title anymore.

Thanks for the heads up. I'll look into this as well.

from anitomy.

Thanks!

from anitomy.