Comments (5)
Interesting, I wasn't aware of this story. It's from 2017, so hopefully exchanges fixed the problem by now, but if we find a case in which this still happens today we can add a synonym table.
from dali-rp2.
@eprbell yeah I'm guessing this is more of a historical quirk. I'm guessing the easiest way to handle this would be to manually manipulate the tables, but I'm wondering if you can think of an easy place to put a synonym table that wouldn't require a ton of work.
from dali-rp2.
Probably inside the first loop of the resolve_transactions(), which is already modifying transaction data.
from dali-rp2.
There is also the case of BCHSV and BSV that we had issues with earlier. I think this might spring up from time to time. There are also smaller assets that share tickers, like GENE.
from dali-rp2.
Here's a more detailed description of how to approach this issue:
- add the synonym table to DEFAULT_CONFIGURATION;
- inside the first for loop of resolve_transactions() check if
transaction.asset
has a synonym (the configuration is passed to this function via theglobal_configuration
parameter;- if there is a synonym reinstantiate the transaction with the new symbol.
from dali-rp2.
Related Issues (20)
- CCXT Pair Converter may not be available for people in the US HOT 5
- CCXT deposits / withdrawals broken for versions 2.5.2+ HOT 1
- Issues with USDC->USD pair conversion HOT 18
- Kraken CSV reader creates too large of cache for multiple assets HOT 4
- Missing transactions with Binance REST plugin HOT 3
- Implement Prezzemolo BFS in the CCXT pair converter HOT 8
- Does dali-rp2 have a .ods plugin for previous outputs? HOT 8
- Investment Expenses -- how calculated? HOT 7
- Bitbank Dali Configuration File Documentation HOT 3
- Error using coinbase plugin: "TypeError: 'NoneType' object is not subscriptable" HOT 6
- Fatal exception: No path found from AR to USD HOT 16
- Separate Folder for Sensitive Information HOT 4
- Error when processing both Coinbase Pro and Coinbase data through REST API HOT 6
- Implement aliases for assets on specific exchanges HOT 12
- Pricing for dates before asset is listed on Binance.com are inaccurate HOT 2
- Weigh vertexes in Djikstra based on monthly volume for the CCXT pair converter HOT 23
- Negative Transaction Fees and transaction_resolver errors HOT 11
- Asset missing from graph HOT 10
- 2 same uniqueID transactions in binance´s dust trade. HOT 3
- Spot price for XXX->YYY not found on any pair converter plugin HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dali-rp2.