Coinbase Pro IntraTransaction fee and spot price about dali-rp2 HOT 6 CLOSED

Thanks for the detailed explanation. Tested again with manual intra CSV for the receiving side and the spot price was fetched from Coinbase Pro. Closing the issue.

from dali-rp2.

For intra-transactions the fee is implicitly defined as crypto_sent - crypto_received: when you add the missing half of the transaction it will get populated. The spot price should have been populated: are you sure you passed the -s option? If you did can you instrument the code around https://github.com/eprbell/dali-rp2/blob/main/src/dali/transaction_resolver.py#L202? Add a few LOGGER.debug calls to see what is happening. If -s has been passed it should get inside _update_spot_price_from_web() and it should read the price from Coinbase Pro.

from dali-rp2.

Dali is indeed calling _update_spot_price_from_web, but the transaction spot_price is None, and it returns right away. Not sure how to fix this without breaking something else. What do you recommend?

from dali-rp2.

Can you add more LOGGER.debug calls inside _update_spot_price_from_web() to see what path it is taking? Also: does this happen for only one transaction or for all of them?

from dali-rp2.

In my limited testing, _update_spot_price_from_web() always exits without doing anything, but for different reasons depending on the transaction.

For "match" transactions (BUY), the spot price is a numeric value upon entry to _update_spot_price_from_web(), so it exits without needing to fetch the price from the web.

For "transfer" / "withdraw" transactions. The function is exiting in this snippet:

    if transaction.spot_price is None:  # type: ignore
        return transaction

from dali-rp2.

Thanks for running the code with instrumentation: that gave me enough context to understand what is happening. This is not a bug, but intended behavior. In intra-transaction the only field that has an effect on taxes (or more precisely on the in-out coin flow) is crypto_fee, which is crypto_sent - crypto_received, as explained above. Since this is an unresolved transaction (there is only one half of it), either crypto_sent or crypto_received are missing and therefore crypto_fee cannot be computed: so the spot_price is also not computed, because it would be useless (it only affects the "taxable" part of the transaction, which is crypto_fee). If you were to complete the transaction by providing the missing half, then the transaction resolver would notice that both crypto_sent and crypto_received are present and therefore it would compute crypto_fee and resolve spot_price. Can you try that and let me know if it works?

from dali-rp2.