Code Monkey home page Code Monkey logo

Comments (4)

envygeeks avatar envygeeks commented on June 2, 2024

Do you have a site I can use to replicate the former issue? As the only way to trace that is to introspect it since there can be a lot of t hings that hit that particular area!

from jekyll-assets.

dramalho avatar dramalho commented on June 2, 2024

You said former but since you have a PR I guess for the Upstream caching, I guess you mean the digest_path issue right? I .. I have it on my blog, but I'll try to create a repo that triggers the thing - I need to remember where I was hitting it :)

Thanks for the Upstream fix, hope the stuff you've been dealing with is ... going well . Thanks Jordon

from jekyll-assets.

envygeeks avatar envygeeks commented on June 2, 2024

I didn't know I had a PR for the caching issue, that's already fixed on master at bc42508 yes, I do mean the latter with digest_path.

from jekyll-assets.

mroch avatar mroch commented on June 2, 2024

i'm running into the same digest_path issue with sprockets 4.

I narrowed it down to using //= link foo.js. I think this is the issue:

https://github.com/rails/sprockets/blob/24c97270fbf6de11b4ffff0311bb427b7a8a3a83/lib/sprockets/base.rb#L88

as far as I can tell, this is what sets environment, but it's setting it on CachedEnvironment, not on Base:

%i(find_asset find_asset!).each do |v|
define_method v do |*a|
super(*a).tap do |m|
m&.environment = self
end
end
end

so the linked asset doesn't have environment set since a different find_asset was called.

from jekyll-assets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.