xds relay fetches incorrect eds resources about xds-relay HOT 4 OPEN

Found the reason for this. The aggregator rule in our private repo specific to Lyft had a bug due to which eds requests were cached on service name. So when svcA asked for eds, the last eds won and overwrote eds for all previous services

from xds-relay.

After adding rules to add resource name for eds, the cache is happy now.

  - rules:
    - match:
        request_type_match:
          types:
            - "type.googleapis.com/envoy.api.v2.RouteConfiguration"
            - "type.googleapis.com/envoy.config.route.v3.RouteConfiguration"
            - "type.googleapis.com/envoy.api.v2.ClusterLoadAssignment"
            - "type.googleapis.com/envoy.config.endpoint.v3.ClusterLoadAssignment"
      result:
        resource_names_fragment:
          element: 0
          action: { exact: true }

from xds-relay.

An important aspect here is that these rules will possibly apply to all users of the project.

from xds-relay.

In the envoy slack we mentioned two alternatives to fix this:

• define an aggregation rules checker, similar to envoy's router check tool.
• implicitly add the resource name to the cache key in case it's not present.

from xds-relay.