Rolling window limits? about ratelimit HOT 10 OPEN

Has there been a decision on an algorithm for rolling window rate limiting yet?

from ratelimit.

Windowed limits are not currently supported.

from ratelimit.

Would you be interested in something like https://github.com/brandur/redis-cell?
This practically shifts the rate limit algorithm implementation from the service to Redis, but I think could be implemented with minimal effort.

from ratelimit.

@andrascz it might be interesting to support something like that, though I think to be useful we would need to support those commands with whatever sharding/cluster system is being used. A single redis host is not going to scale in most deployments.

from ratelimit.

I am not 100% sure as I did not try it on cluster, but based on brandur/redis-cell#30, either it is already working or needs minimal tweaks.

from ratelimit.

@mattklein123 If the redis-cell support sentinel and cluster setup, will envoyproxy/ratelimit use it? Or you are inclined toward internal code implementation?

from ratelimit.

@mattklein123 If the redis-cell support sentinel and cluster setup, will envoyproxy/ratelimit use it?

Can you describe more what you are proposing?

from ratelimit.

There are two possible approaches to support rolling window limits:

1. Use redis-cell then create a new cache impl that uses redis-cell commands
2. Implement rolling window limit logic in new cache impl with basic Redis commands

The first approach would create a dependency on redis-cell module and shifting implementation to Redis.
This is a tradeoff between creating dependency vs maintaining implementation, which approach does the maintainer prefer?

from ratelimit.

In general I think (2) is better, but I have no objection to having an option that requires redis-cell as long as it is opt-in.

from ratelimit.

I don't think there was a decision made to strictly use a certain algorithm. There was work being done in #243 and #193 to implement rolling window but it's gone stale unfortunately.

from ratelimit.