Enable HPA for Envoy Proxy introduce unexpected behavior about gateway HOT 7 CLOSED

yeah, that is the user being explicit, if the user sets both replica and hpa, they will encounter the battle of the controllers, we can flag it, but its legal in k8s today
we could add a note similar to this https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/#migrating-deployments-and-statefulsets-to-horizontal-autoscaling
saying dont set replica if hpa is set

make sense, let me adjust it then

from gateway.

hi folks @arkodg @zirain , it looks like this issue is still happening, as I observed, it looks like because we are leveraging the Update API instead of Patch API in the infra-client code, below:

gateway/internal/infrastructure/kubernetes/infra_client.go

Lines 40 to 45 in c655811

	if updateChecker() {
	specific.SetUID(current.GetUID())
	if err := cli.Client.Update(ctx, specific); err != nil {
	return fmt.Errorf("for Update: %w", err)
	}
	}

Therefore, I tried in my local to change with Patch API, it worked as expected. Should I re-open this issue, or create a new issue?

yes please open a new issue for this ....

from gateway.

if this is reasonable, I would like to work on this

from gateway.

looks like we've discussed this a while ago #703 (comment)
imo the fix here is to not set any default replica, which we are doing today, this code needs to be removed

from gateway.

imo the fix here is to not set any default replica, which we are doing today, this code needs to be removed

However @arkodg , it seems to me that unsetting the default replica only addresses the default value behavior, but when a user accidentally sets EnvoyProxy.spec.provider.kubernetes.envoyDeployment.replicas, it will still revert to its replica value, right? wdyt?

from gateway.

imo the fix here is to not set any default replica, which we are doing today, this code needs to be removed

However @arkodg , it seems to me that unsetting the default replica only addresses the default value behavior, but when a user accidentally sets EnvoyProxy.spec.provider.kubernetes.envoyDeployment.replicas, it will still revert to its replica value, right? wdyt?

yeah, that is the user being explicit, if the user sets both replica and hpa, they will encounter the battle of the controllers, we can flag it, but its legal in k8s today
we could add a note similar to this https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/#migrating-deployments-and-statefulsets-to-horizontal-autoscaling
saying dont set replica if hpa is set

from gateway.

hi folks @arkodg @zirain , it looks like this issue is still happening, as I observed, it looks like because we are leveraging the Update API instead of Patch API in the infra-client code, below:

Therefore, I tried in my local to change with Patch API, it worked as expected. Should I re-open this issue, or create a new issue?

from gateway.