Unexpected Pod while deleting gateways with merge gateways enabled about gateway HOT 9 OPEN

Found the reason that causing this problem, and it does not seems like a bug to me, so closing this one now.

from gateway.

It is also happening when applying resources, I have seen this in the past, is this only happening with merged gateways @shawnh2?

This behaviour seems similar to what was fixed before #2395

Since we changed the watchable interface to a map, which is unordered, wonder what is causing these unnecessary updates.

yes, it only happens with merge gateways. it's mainly caused by the step 2 which I described above.

from gateway.

This problem will not exist if the Gateways and HTTPRoutes got deleted first, then delete the rest GatewayClass and EP.

If the GatewayClass and EP got deleted first, the merge gateways feature fails, so all 3 gateways will be created separately.

So by applying k delete -f mg.yaml, the GatewayClass and EP will be deleted first, causing all 3 gateways to be created separately and then got deleted immediately.

from gateway.

hey @shawnh2 if the GWC gets deleted first, why will the GWs get created again ?

from gateway.

maybe related to #2659

from gateway.

hey @shawnh2 if the GWC gets deleted first, why will the GWs get created again ?

by answering this question, i toke a closer look at EG reconcile method, and here is what i found.

1. if the GWC got deleted first, it will still appears in acceptedGCs list, because it won't pass the finializer check:
   

   gateway/internal/provider/kubernetes/controller.go

   Lines 153 to 154 in cf46fbe

   	if !gwClass.DeletionTimestamp.IsZero() &&
   	!slice.ContainsString(gwClass.Finalizers, gatewayClassFinalizer) {

2. then EG will take the deleted GWC name as index to list the GTWs that associated with, we can still get all the GTWs here since they are not be deleted
   

   gateway/internal/provider/kubernetes/controller.go

   Lines 625 to 626 in cf46fbe

   	if err := r.client.List(ctx, gatewayList, &client.ListOptions{
   	FieldSelector: fields.OneTermEqualSelector(classGatewayIndex, acceptedGC.Name),

   
   so all the GTWs will be recreated like I described above

3. we cannot fall into this logic to remove the finializer for GWC, so the GWC will never pass the finializer check in step 1, remain accepted
   

   gateway/internal/provider/kubernetes/controller.go

   Line 347 in cf46fbe

   if len(resourcesMap[acceptedGC.Name].Gateways) == 0 {

from gateway.

I'm not sure what expected behavior of this should be?

IMO, at least all the GTWs should be in NOT ACCEPT status and all the related resources like Service, Deployements etc should not be recreated.

from gateway.

It is also happening when applying resources, I have seen this in the past, is this only happening with merged gateways @shawnh2?
This behaviour seems similar to what was fixed before #2395
Since we changed the watchable interface to a map, which is unordered, wonder it is causing these unnecessary updates.

from gateway.

I see, this is matching the deletion issue

from gateway.