Title : HDS support for gRPC Health Checks Desc

Correct me if I'm mistaken but I don't see an any tests in <a href="https://github.com

I see. I might have mistaken that with these test <a href="https://github.com/envoypro

Here is a sample config: <div class="highlight highlight-source-json notranslate p

HDS support for gRPC Health Checks about envoy HOT 5 OPEN

sean-jeffrey commented on June 23, 2024

HDS support for gRPC Health Checks

from envoy.

Comments (5)

sean-jeffrey commented on June 23, 2024

I'm happy to submit a PR if the suggestion is reasonable :)

from envoy.

adisuissa commented on June 23, 2024

Can you explain the problem in a bit more detail and provide the config that is problematic?
I think the tests in https://github.com/envoyproxy/envoy/blob/main/test/integration/hds_integration_test.cc are covering the right cases, no?

from envoy.

sean-jeffrey commented on June 23, 2024

Correct me if I'm mistaken but I don't see an any tests in https://github.com/envoyproxy/envoy/blob/main/test/integration/hds_integration_test.cc that use a gRPC health check specifier, only different forms of HTTP and TCP.

To restate the problem: I want to use the health discovery service to configure a gRPC health check

envoy/api/envoy/config/core/v3/health_check.proto

Line 205 in 21fba62

message GrpcHealthCheck {

but the config fails due to the validation at https://github.com/envoyproxy/envoy/blob/main/source/common/upstream/health_checker_impl.cc#L70 which requires the upstream cluster to be explicitly configured with the HTTP/2 feature.
As far as I can tell the health discovery service does not offer a means for setting the HTTP/2 feature on an upstream cluster and so I'm at an impasse.

If that doesn't clear it up I can provide a config.

from envoy.

adisuissa commented on June 23, 2024

I see. I might have mistaken that with these test https://github.com/envoyproxy/envoy/blob/main/test/integration/health_check_integration_test.cc.
Can you provide a config?

from envoy.

sean-jeffrey commented on June 23, 2024

Here is a sample config:

{
  "cluster_health_checks": [
    {
      "cluster_name": "my-cluster",
      "health_checks": [
        {
          "timeout": {
            "seconds": 1
          },
          "interval": {
            "seconds": 1
          },
          "unhealthy_threshold": {
            "value": 1
          },
          "healthy_threshold": {
            "value": 1
          },
          "HealthChecker": {
            "GrpcHealthCheck": {}
          },
          "no_traffic_interval": {
            "seconds": 1
          }
        }
      ],
      "locality_endpoints": [
        {
          "endpoints": [
            {
              "address": {
                "Address": {
                  "SocketAddress": {
                    "address": "10.0.0.1",
                    "PortSpecifier": {
                      "PortValue": 3000
                    }
                  }
                }
              }
            }
          ]
        }
      ]
    }
  ],
  "interval": {
    "seconds": 2
  }
}