Code Monkey home page Code Monkey logo

Comments (4)

Yufeireal avatar Yufeireal commented on June 24, 2024

Here is another example, another traffic request jumped too
image

from envoy.

Yufeireal avatar Yufeireal commented on June 24, 2024

Oh, the requests might not be doubled. It's websocket connection got terminated and reconnected, looks like this is expected when I update the filter above(listener replace will cause client reconnect).
Would be appreciate if someone can share some insights under the hood and will it helpful if I configure drain time for this , thanks!

from envoy.

adisuissa avatar adisuissa commented on June 24, 2024

I'm not certain what kind of update happens in your case, but in general:

  • If a listener (LDS) is updated - the old listener will be drained (see docs, and this) and a new one will be created to serve the new connections.
  • If you just need to update the filters (and not the listener), you may be able to use ECDS - this will avoid draining the listener, but will only impact new connections.

from envoy.

Yufeireal avatar Yufeireal commented on June 24, 2024

Thanks a lot for the info.
I did patched this to listener's filterChain, so should be an expected behavior from Envoy. Will also look at the doc links you shared. I think at least I have two things worth to try now:

  1. Tune the drain time when envoy hotrestart, maybe can do some manual rollout for envoy pods while they draining.
  2. Yeah, I will experiment patching this to extension using ECDS instead of LDS, see what I can get.

from envoy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.