Code Monkey home page Code Monkey logo

Comments (8)

htuch avatar htuch commented on July 28, 2024

@mpwarres @alyssawilk

from envoy.

alyssawilk avatar alyssawilk commented on July 28, 2024

I'm not familar with the filter but we have documented steps on conversion here:
https://github.com/envoyproxy/envoy/blob/main/source/docs/upstream_filters.md
that filter owners can use to assess and convert!

from envoy.

juanmolle avatar juanmolle commented on July 28, 2024

Thanks @alyssawilk I try to convert it following your instructions but I see at the moment to get the clusterManager in this line https://github.com/envoyproxy/envoy/blob/main/source/extensions/filters/http/wasm/wasm_filter.cc#L26 it is not available and the assert broke here https://github.com/envoyproxy/envoy/blob/main/source/server/server.cc#L144

I'm creating the config as static. Not sure if the issue is that inserting the filter during the cluster initialization could be the reason this config is still not available.

What I did is to create a mock of the clusterManager to let me create the wasm filter and I could run a simple wasm. but I don't know if it is possible to use the real clusterManager. populate it later in wasm filter, of having a proxy object with lazy initialization. I guess this cluster manager is used later in the execution when the wasm needs to make a call, for example.

from envoy.

alyssawilk avatar alyssawilk commented on July 28, 2024

from envoy.

juanmolle avatar juanmolle commented on July 28, 2024

The workaround is not something we can use, I can upload a PR to make it easy understand what the problem is.

from envoy.

juanmolle avatar juanmolle commented on July 28, 2024

@alyssawilk If you have a momento to take a look #33119

from envoy.

github-actions avatar github-actions commented on July 28, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

from envoy.

github-actions avatar github-actions commented on July 28, 2024

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

from envoy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.