perf: replace evbuffer about envoy HOT 8 CLOSED

I volunteer to work on this, because the ioctl in libevent is surprisingly time-consuming.

from envoy.

@brian-pane great, will assign this over to you. I would love to see this fixed also but have never had the time. A couple of thoughts as there are solutions that I think don't involve rewriting the entire buffer implementation if you are interested in a shortcut:

• We could try for a patch to libevent itself to have an option to not do the ioctl call. Not sure if they would accept it or not, though seems reasonable to me.
• We could just remove the read() and write() calls from Envoy's buffer interface. Then, we can allocate space directly using reservation, and just call readv()/writev() directly. This has the large added benefit of untangling the FD from the buffer implementation which is needed anyway from some of the FD abstraction work that is happening via the Cisco/VPP folks.

So I guess in writing this I wonder if maybe it would be a better use of your time to just do my second suggestion above? (If you completely rewrite the buffer implementation I would ask for that to be done anyway).

from envoy.

+1 for removing the read and write calls from the buffer API. That will enable the buffer implementation and the I/O implementation to evolve separately.

from envoy.

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

from envoy.

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

from envoy.

I was able to remove the ioctl call, but it may be a while before I have time to work on a complete replacement of evbuffer. It may make sense to return this issue to "help wanted" state, in case anybody else has time to work on it.

from envoy.

TBH with the ioctol gone I'm not sure how much it matters anymore and maybe we should just close this. But I marked "help wanted" for now.

from envoy.

Going to go ahead and close this as I don't think it's a priority anymore. We can revisit if it comes up again.

from envoy.