Comments (4)
(Also cc @jmacd)
The only challenge will be the part of the code that does a flush... OT won't / shouldn't have an opinion about serialization formats, esp for out-of-band data, so some sort of cast to the LightStep tracer will be necessary there... but all of the actual Span creation, tagging, etc, can and should be pure OpenTracing code.
@jmacd: how much has the lightstep Tracer+Span interface diverged from whatever's at head in OT-CPP?
from envoy.
My proposal is to factor the existing lightstep API into three parts, opentracing API, basictracer implementation, and lightstep recorder. This approach would defer any attempt to coordinate with the C++98 work that was done in the openctracing-cpp repo.
from envoy.
@bensigelman @jmacd will defer to both of you on best way of moving forward. Flexible on timeline also if there is more work to do on C++ OT first.
from envoy.
I'm going to close this as won't fix until there is a compelling reason to implement.
from envoy.
Related Issues (20)
- envoy_reloadable_features_lowercase_scheme deprecation
- envoy_reloadable_features_proxy_status_upstream_request_timeout deprecation
- envoy_reloadable_features_stop_decode_metadata_on_local_reply deprecation
- envoy_reloadable_features_token_passed_entirely deprecation
- envoy_reloadable_features_use_cluster_cache_for_alt_protocols_filter deprecation
- envoy_restart_features_send_goaway_for_premature_rst_streams deprecation
- Envoy Logs are on in json format and Logviewer identified them as error HOT 1
- IP Filtering with source: remote_ip and x-forwarded-for IP address does not work HOT 2
- gRPC HTTP/1.1 bridge could map gRPC codes to HTTP response codes
- HTTP Connection Manager: Add the ability to have per worker stats HOT 2
- Newer release available `com_github_bazelbuild_buildtools`: v7.1.1 (current: v7.1.0)
- Newer release available `com_github_grpc_grpc`: v1.62.2 (current: v1.59.4)
- Newer release available `com_google_protobuf`: v27.0-rc1 (current: v24.4) HOT 1
- Envoy 1.30.0 docker image is not working. It is crashing while creating container HOT 6
- Why accept x-forwarded-* headers when Envoy as edge proxy ? HOT 3
- QuicHttpIntegrationTests/QuicHttpIntegrationTest.Http3ClientKeepalive is flaky
- IpVersions/TcpListenerImplTest.EachQueuedConnectionShouldQueryTheLoadShedPoint is flaky
- tls: add histogram measuring ssl negotiation latency HOT 1
- connections are not uniformly spread across the workers HOT 1
- Question: How can we defer bootstrap extension to be run after envoy server completely starts? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from envoy.