Code Monkey home page Code Monkey logo

Comments (4)

bhs avatar bhs commented on May 25, 2024

(Also cc @jmacd)

The only challenge will be the part of the code that does a flush... OT won't / shouldn't have an opinion about serialization formats, esp for out-of-band data, so some sort of cast to the LightStep tracer will be necessary there... but all of the actual Span creation, tagging, etc, can and should be pure OpenTracing code.

@jmacd: how much has the lightstep Tracer+Span interface diverged from whatever's at head in OT-CPP?

from envoy.

jmacd avatar jmacd commented on May 25, 2024

My proposal is to factor the existing lightstep API into three parts, opentracing API, basictracer implementation, and lightstep recorder. This approach would defer any attempt to coordinate with the C++98 work that was done in the openctracing-cpp repo.

from envoy.

mattklein123 avatar mattklein123 commented on May 25, 2024

@bensigelman @jmacd will defer to both of you on best way of moving forward. Flexible on timeline also if there is more work to do on C++ OT first.

from envoy.

mattklein123 avatar mattklein123 commented on May 25, 2024

I'm going to close this as won't fix until there is a compelling reason to implement.

from envoy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.